Skip to content

Commit 06dff90

Browse files
authored
fix(html-reporter): use selected run for TraceLink instead of first run (microsoft#41288)
1 parent 91b4d08 commit 06dff90

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

packages/html-reporter/src/links.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -132,8 +132,9 @@ export const AttachmentLink: React.FunctionComponent<{
132132
);
133133
};
134134

135-
export const TraceLink: React.FC<{ test: TestCaseSummary, trailingSeparator?: boolean, dim?: boolean }> = ({ test, trailingSeparator, dim }) => {
136-
const firstTraces = test.results.map(result => result.attachments.filter(attachment => attachment.name === 'trace')).filter(traces => traces.length > 0)[0];
135+
export const TraceLink: React.FC<{ test: TestCaseSummary, run?: number, trailingSeparator?: boolean, dim?: boolean }> = ({ test, run, trailingSeparator, dim }) => {
136+
const resultsToCheck = run !== undefined && test.results[run] ? [test.results[run]] : test.results;
137+
const firstTraces = resultsToCheck.map(result => result.attachments.filter(attachment => attachment.name === 'trace')).filter(traces => traces.length > 0)[0];
137138
if (!firstTraces)
138139
return undefined;
139140

packages/html-reporter/src/testCaseView.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ export const TestCaseView: React.FC<{
6262
</CopyToClipboardContainer>
6363
</div>
6464
<div style={{ flex: 'auto' }}></div>
65-
<TraceLink test={test} trailingSeparator={true} />
65+
<TraceLink test={test} run={selectedResultIndex} trailingSeparator={true} />
6666
<div className='test-case-duration'>{msToString(test.duration)}</div>
6767
</div>
6868
<ProjectAndTagLabelsView style={{ marginLeft: '6px' }} projectNames={report.json().projectNames} activeProjectName={test.projectName} otherLabels={test.tags} />

0 commit comments

Comments
 (0)