Skip to content

Fix an old bug where a TCB image was sent UD flipped to GMT. #1833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joa-quim merged 3 commits into from
Oct 15, 2025
Merged

Fix an old bug where a TCB image was sent UD flipped to GMT. #1833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ac70a0
Temporarily run tests only on 1.10 (twice fast)
joa-quim Oct 15, 2025
de42722
Don't treat input Bool matyrix as a grid. It's an image.
joa-quim Oct 15, 2025
d196a00
Fix an old bug where a TCB image was sent UD flipped to GMT.
joa-quim Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ jobs:
#- '1.7' # Leave this line unchanged. '1' will automatically expand to the latest stable 1.x release of Julia.
- '~1.10.0-0'
#- '~1.11.0-0'
- '~1.12.0-0'
- 'nightly'
#- '~1.12.0-0'
#- 'nightly'
os:
- ubuntu-latest
#- ubuntu-20.04
Expand Down
2 changes: 1 addition & 1 deletion src/gmt_main.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -990,7 +990,7 @@ function image_init(API::Ptr{Nothing}, Img::GMTimage)::Ptr{GMT_IMAGE}
img = copy(Img.image)
GMT_Change_Layout(API, GMT_IS_IMAGE, "BRP", 0, I, img); # Convert to BRP. Not 100% on the > 2 though.
elseif (!mem_owned_by_gmt && size(img,3) == 1 && Img.layout[2] == 'C')
img = fliplr(img')
img = (Img.layout[1] == 'T') ? collect(img') : fliplr(img') # T(o) case doesn't need a fliud (that is a fliplr because transposition)
end
Ib.data = pointer(img)
unsafe_store!(I, Ib)
Expand Down
4 changes: 2 additions & 2 deletions src/imshow.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@ function imshow(arg1, x::AbstractVector{Float64}=Float64[], y::AbstractVector{Fl
!is_image && (Gg = arg1)
#snif_GI_set_CTRLlimits(arg1) # Set CTRL.limits to be eventually used by J=:guess
end
elseif (isa(arg1, Array{UInt8}) || isa(arg1, Array{UInt16,3}))
Gi = mat2img(arg1; kw...)
elseif (isa(arg1, Array{UInt8}) || isa(arg1, Array{UInt16,3}) || isa(arg1, Array{Bool}) || isa(arg1, BitMatrix))
Gi = isa(arg1, BitMatrix) ? mat2img(collect(arg1); kw...) : mat2img(arg1; kw...)
call_img = true
elseif (isa(arg1, GDtype) || isa(arg1, GMTfv) || isa(arg1, Vector{GMTfv}) || (isa(arg1, AbstractVecOrMat{<:Real}) && size(arg1,2) <= 4) || (isa(arg1, Gdal.AbstractDataset) || isa(arg1, Gdal.AbstractGeometry)))
(isa(arg1, Gdal.AbstractDataset) || isa(arg1, Gdal.AbstractGeometry)) && (arg1 = gd2gmt(arg1))
Expand Down
Loading