kwargs protection: plotting modules#1919
Merged
Merged
Conversation
Split entry points from main logic in plotting module wrappers
so that kwargs are converted to Dict{Symbol,Any} via init_module
in thin wrappers before calling the main function. This prevents
Julia recompilation when kwargs change.
Affected modules: plot (fill_between, helper_hvband, ternary),
pslegend, psmask, psrose, pssolar, pswiggle, gmtlogo, windbarbs,
psvelo, psmeca/coupe, gmtisf.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1919 +/- ##
==========================================
+ Coverage 85.68% 85.87% +0.18%
==========================================
Files 187 187
Lines 27524 27551 +27
==========================================
+ Hits 23584 23659 +75
+ Misses 3940 3892 -48 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dict{Symbol,Any}viainit_modulein thin wrappers before calling the main functionTest plan
Vd=2smoke tests passtest_B-GMTs.jlpasses (pre-existing failure on missingtest_ds_with_comment.datunrelated)🤖 Generated with Claude Code