Skip to content

Commit 6aef030

Browse files
joa-quimclaude
andcommitted
Fix build.jl: extract zips into package root, not deps/build
Both zips encode paths relative to the package root (deps/build/gmtvtk.dll, data/..., src/...) since that's what CPack's install() DESTINATION values say. Extracting into deps/build/ instead nested everything one level too deep (deps/build/deps/build/gmtvtk.dll), so the DLL never landed where libgmtvtk.jl looks for it. Verified by unzipping iGMT-win64-full.zip into a package-root-rooted dir and confirming deps/build/gmtvtk.dll appears. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
1 parent d936a1c commit 6aef030

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

deps/build.jl

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@ using Downloads
1616
const REPO = "GenericMappingTools/InteractiveGMT"
1717
const DLL_TAG = "dll-latest" # fixed tag; its one asset is re-uploaded in place, never retagged
1818

19-
const DEPS_DIR = @__DIR__
20-
const BUILD_DIR = joinpath(DEPS_DIR, "build")
21-
const MARKER = joinpath(BUILD_DIR, ".full_runtime_installed")
19+
const DEPS_DIR = @__DIR__
20+
const PKG_ROOT = normpath(joinpath(DEPS_DIR, "..")) # zip paths are relative to here (deps/build/..., src/..., data/...)
21+
const MARKER = joinpath(DEPS_DIR, "build", ".full_runtime_installed")
2222

2323
function runtime_tag()
2424
f = joinpath(DEPS_DIR, "RUNTIME_VERSION")
@@ -45,11 +45,11 @@ end
4545
function main()
4646
if !isfile(MARKER)
4747
# First install: full runtime bundle, pinned to a coarse, rarely-bumped tag.
48-
fetch_and_extract(release_url(runtime_tag(), "iGMT-win64-full.zip"), BUILD_DIR)
48+
fetch_and_extract(release_url(runtime_tag(), "iGMT-win64-full.zip"), PKG_ROOT)
4949
touch(MARKER)
5050
else
5151
# Update: DLL only, always the same rolling tag/asset.
52-
fetch_and_extract(release_url(DLL_TAG, "gmtvtk-win64.zip"), BUILD_DIR)
52+
fetch_and_extract(release_url(DLL_TAG, "gmtvtk-win64.zip"), PKG_ROOT)
5353
end
5454
@info "InteractiveGMT: gmtvtk binaries installed"
5555
end

0 commit comments

Comments
 (0)