Figure.pygmtlogo: Remove the additional black outline for the black-and-white dark-theme logo (#4638)

Author: seisman

pygmt/src/pygmtlogo.py

@@ -216,17 +216,6 @@ def _compass_lines():
     # Upper vertical line
     fig.plot(data=_vline_coords(), fill=red, perspective=True)
 
-    # Outline around the shape for black and white color with dark theme
-    if not color and theme == "dark":
-        fig.plot(
-            x=0,
-            y=0,
-            style=f"{symbol}{size_shape + thick_shape}c",
-            pen=f"{thick_comp / 2.0}c,{color_bg}",
-            perspective=True,
-            no_clip=True,
-        )
-
     # Add wordmark "PyGMT"
     if wordmark != "none":
         fig.text(text=f"@;{color_py};Py@;;@;{color_gmt};GMT@;;", **args_text_wm)

pygmt/tests/baseline/test_pygmtlogo_circle_no_wordmark.png.dvc

@@ -1,5 +1,5 @@
 outs:
-- md5: 781ac55a32194d2818a1d96ab2d32727
-  size: 31485
+- md5: fdc90d2867bcbc096bcf5a9303d15ddf
+  size: 31962
   hash: md5
   path: test_pygmtlogo_circle_no_wordmark.png

pygmt/tests/test_pygmtlogo.py

@@ -4,7 +4,7 @@
 
 import pytest
 from pygmt import Figure
-from pygmt.params import Axis, Position
+from pygmt.params import Axis, Frame, Position
 from pygmt.src.pygmtlogo import _create_logo
 
 
@@ -29,23 +29,20 @@ def test_pygmtlogo_circle_no_wordmark():
     and colored/black-and-white versions.
     """
     fig = Figure()
-    fig.basemap(region=[-0.5, 5.0, -0.5, 5.0], projection="x1c", frame=Axis(grid=0.5))
-    fig.pygmtlogo(
-        position=Position((1, 3.5), anchor="CM", cstype="mapcoords"),
-        theme="light",
-    )
-    fig.pygmtlogo(
-        position=Position((3.5, 3.5), anchor="CM", cstype="mapcoords"),
-        theme="dark",
-    )
-    fig.pygmtlogo(
-        position=Position((1, 1), anchor="CM", cstype="mapcoords"),
-        theme="light",
-        color=False,
-    )
-    fig.pygmtlogo(
-        position=Position((3.5, 1), anchor="CM", cstype="mapcoords"),
-        theme="dark",
-        color=False,
+    fig.basemap(
+        region=[-0.5, 5.0, -0.5, 5.0],
+        projection="x1c",
+        frame=Frame(fill="gray", axis=Axis(grid=0.5)),
     )
+    for (x, y), theme, color in [
+        ((1.0, 3.5), "light", True),
+        ((3.5, 3.5), "dark", True),
+        ((1.0, 1.0), "light", False),
+        ((3.5, 1.0), "dark", False),
+    ]:
+        fig.pygmtlogo(
+            position=Position((x, y), anchor="CM", cstype="mapcoords"),
+            theme=theme,
+            color=color,
+        )
     return fig