Skip to content

Fix the failing tests for the updated gravimetric grids#4367

Merged
seisman merged 1 commit into
mainfrom
fix/gravimetric
Jan 23, 2026
Merged

Fix the failing tests for the updated gravimetric grids#4367
seisman merged 1 commit into
mainfrom
fix/gravimetric

Conversation

@weiji14

@weiji14 weiji14 commented Jan 22, 2026

Copy link
Copy Markdown
Member

Description of proposed changes

Specifically the earth_faa, earth_faaerror, earth_ndefl, earth_edefl and earth_vgg grids. Xref GenericMappingTools/gmtserver-admin#291

Fixes #

Preview:

Guidelines

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash command is:

  • /format: automatically format and lint the code

Specifically the `earth_faa`, `earth_ndefl`, `earth_edefl` and `earth_vgg` grids. Xref GenericMappingTools/gmtserver-admin#291
@weiji14 weiji14 added this to the 0.19.0 milestone Jan 22, 2026
@weiji14 weiji14 self-assigned this Jan 22, 2026
@weiji14 weiji14 added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Jan 22, 2026
@Esteban82

Copy link
Copy Markdown
Member

Out of curiosity: what is the main goal of these tests?
Are they meant to verify that the provided grids are correct, to check that the command runs as expected, or something else?

@weiji14

weiji14 commented Jan 22, 2026

Copy link
Copy Markdown
Member Author

Yes, we're just checking that the function runs ok, and the grids returns the expected values (no NaNs, etc). It helps when we do major refactoring, to ensure nothing goes wrong.

@Esteban82

Copy link
Copy Markdown
Member

It sounds to me that you could use the static server instead.
https://static.generic-mapping-tools.org/

This is its readme file:

# This directory is meant to be static, i.e., we only place unchanged data
# sets that our test scripts need to use so that we do not get massive test
# failures when the topography is updated a bit.

Right now it doesn't have any gravimetric data, but I think we could add it.

@seisman seisman merged commit 6440d26 into main Jan 23, 2026
24 of 33 checks passed
@seisman seisman deleted the fix/gravimetric branch January 23, 2026 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants