pygmt.project: Add input validation for geometry parameters#4415
Merged
seisman merged 17 commits intoFeb 21, 2026
Conversation
Add input validation for 'endpoint', 'pole', and 'azimuth' to check for only one paramter being passed. Add testing to check that appropriate error is raised.
seisman
reviewed
Feb 14, 2026
seisman
reviewed
Feb 14, 2026
seisman
added
maintenance
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Contributor
Author
|
/format |
seisman
reviewed
Feb 20, 2026
| with pytest.raises(GMTParameterError): | ||
| project( | ||
| center=[0, -1], | ||
| generate=0.5, |
Member
There was a problem hiding this comment.
When generate is used, data should not be allowed, right?
Contributor
Author
There was a problem hiding this comment.
The way I read the docs, the it just says that data will be ignored if generate is set. I removed this line from my PR. Should there be an input validation for data when generate is set?
seisman
reviewed
Feb 21, 2026
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Contributor
Author
|
/format |
seisman
reviewed
Feb 21, 2026
seisman
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add input validation for 'endpoint', 'pole', and 'azimuth' to check for only one paramter being passed. Add testing to check that appropriate error is raised.