-
Notifications
You must be signed in to change notification settings - Fork 245
Mark test_binstats_quantile as xfail in the GMT Legacy Tests workflow #4087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
cdc8b25
b37898b
dd5abb4
3df87bb
1dc2e42
bf228bd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,7 +6,9 @@ | |
|
|
||
| import numpy.testing as npt | ||
| import pytest | ||
| from packaging.version import Version | ||
| from pygmt import binstats | ||
| from pygmt.clib import __gmt_version__ | ||
| from pygmt.enums import GridRegistration, GridType | ||
| from pygmt.helpers import GMTTempFile | ||
|
|
||
|
|
@@ -67,7 +69,13 @@ def test_binstats_quantile(): | |
| assert temp_grid.dims == ("y", "x") | ||
| assert temp_grid.gmt.gtype is GridType.CARTESIAN | ||
| assert temp_grid.gmt.registration is GridRegistration.GRIDLINE | ||
| assert temp_grid.dtype == "float32" | ||
| npt.assert_allclose(temp_grid.max(), 15047685) | ||
| npt.assert_allclose(temp_grid.min(), 53) | ||
| npt.assert_allclose(temp_grid.median(), 543664.5) | ||
| npt.assert_allclose(temp_grid.mean(), 1661363.6) | ||
| if Version(__gmt_version__) > Version("6.4.0"): | ||
| npt.assert_allclose(temp_grid.min(), 53) | ||
| npt.assert_allclose(temp_grid.median(), 543664.5) | ||
| npt.assert_allclose(temp_grid.mean(), 1661363.6) | ||
| else: # TODO(GMT>=6.5.0): Remove if-condition with different min/median/mean values | ||
| npt.assert_allclose(temp_grid.min(), 0) | ||
| npt.assert_allclose(temp_grid.median(), 330700.0) | ||
| npt.assert_allclose(temp_grid.mean(), 1459889.1) | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unsure which values are the correct ones. Do we want to check in upstream GMT on what might have changed
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Likely related to GenericMappingTools/gmt#8243.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for the reminder, forgot about that thread! Have changed to an xfail in commit 1dc2e42 |
||
Uh oh!
There was an error while loading. Please reload this page.