From 1cde3c02deffcfcbceccfced72d0ad862b437889 Mon Sep 17 00:00:00 2001 From: Dongdong Tian Date: Sun, 12 Oct 2025 21:19:15 +0800 Subject: [PATCH 1/3] Revert "CI: Temporarily disable the Docs workflow on Windows (#4151)" This reverts commit 01dc17293abc11ccc624b5dc9f81a71da2a39f56. --- .github/workflows/ci_docs.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/ci_docs.yml b/.github/workflows/ci_docs.yml index c85c0cd86c1..e41a805c5c5 100644 --- a/.github/workflows/ci_docs.yml +++ b/.github/workflows/ci_docs.yml @@ -53,8 +53,7 @@ jobs: strategy: fail-fast: false matrix: - os: [ubuntu-latest, macos-latest] - # os: [ubuntu-latest, macos-latest, windows-latest] + os: [ubuntu-latest, macos-latest, windows-latest] # Is it a draft Pull Request (true or false)? isDraft: - ${{ github.event.pull_request.draft }} From f2c863bfcc180710e0de06e06f4c2d491f016cbb Mon Sep 17 00:00:00 2001 From: Dongdong Tian Date: Fri, 5 Jun 2026 10:06:03 +0800 Subject: [PATCH 2/3] Revert "CI: Allow Tests and Docs workflows to pass for segment fault on Windows (#4664)" This reverts commit a2862499fbafde55c09ee7761292d5da247d171a. --- .github/workflows/ci_docs.yml | 22 ++++------------------ .github/workflows/ci_tests.yaml | 10 +--------- 2 files changed, 5 insertions(+), 27 deletions(-) diff --git a/.github/workflows/ci_docs.yml b/.github/workflows/ci_docs.yml index baf28850e06..4080b6bea1d 100644 --- a/.github/workflows/ci_docs.yml +++ b/.github/workflows/ci_docs.yml @@ -53,7 +53,8 @@ jobs: strategy: fail-fast: false matrix: - os: [ubuntu-latest, macos-latest, windows-latest] + os: [ubuntu-latest, macos-latest] + # os: [ubuntu-latest, macos-latest, windows-latest] # Is it a draft Pull Request (true or false)? isDraft: - ${{ github.event.pull_request.draft }} @@ -135,25 +136,10 @@ jobs: python -m pip install dist/* - name: Build the HTML documentation - run: | - log_file="${RUNNER_TEMP}/sphinx-html.log" - make -C doc clean html 2>&1 | tee "${log_file}" - exit_code=${PIPESTATUS[0]} - if [[ "${RUNNER_OS}" == "Windows" && "${exit_code}" -eq 2 ]] && grep -q "make: .* Error 2816" "${log_file}"; then - echo "Sphinx HTML build exited with make error 2816 (segmentation fault) on Windows; allowing workflow to continue." - exit 0 - fi - exit "${exit_code}" + run: make -C doc clean html - name: Build the PDF documentation - run: | - log_file="${RUNNER_TEMP}/sphinx-latex.log" - make -C doc latex 2>&1 | tee "${log_file}" - exit_code=${PIPESTATUS[0]} - if [[ "${RUNNER_OS}" == "Windows" && "${exit_code}" -eq 2 ]] && grep -q "make: .* Error 2816" "${log_file}"; then - echo "Sphinx LaTeX build exited with make error 2816 (segmentation fault) on Windows; allowing workflow to continue." - exit 0 - fi + run: make -C doc pdf - name: Create the HTML ZIP archive and rename the PDF file run: | diff --git a/.github/workflows/ci_tests.yaml b/.github/workflows/ci_tests.yaml index 504d7f51c39..0a456fc6ae2 100644 --- a/.github/workflows/ci_tests.yaml +++ b/.github/workflows/ci_tests.yaml @@ -189,15 +189,7 @@ jobs: # Run the regular tests - name: Run tests - run: | - log_file="${RUNNER_TEMP}/pytest.log" - make test PYTEST_EXTRA="-r P --reruns 2" 2>&1 | tee "${log_file}" - exit_code=${PIPESTATUS[0]} - if [[ "${RUNNER_OS}" == "Windows" && "${exit_code}" -eq 2 ]] && grep -q "make: .* Error 2816" "${log_file}"; then - echo "Tests exited with make error 2816 (segmentation fault) on Windows; allowing workflow to continue." - exit 0 - fi - exit "${exit_code}" + run: make test PYTEST_EXTRA="-r P --reruns 2" # Upload diff images on test failure - name: Upload diff images if any test fails From bc26fa9d341333d4e030b812810eaceebc71ab31 Mon Sep 17 00:00:00 2001 From: Dongdong Tian Date: Fri, 5 Jun 2026 10:06:28 +0800 Subject: [PATCH 3/3] Fix --- .github/workflows/ci_docs.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/ci_docs.yml b/.github/workflows/ci_docs.yml index 4080b6bea1d..b2374edb952 100644 --- a/.github/workflows/ci_docs.yml +++ b/.github/workflows/ci_docs.yml @@ -53,8 +53,7 @@ jobs: strategy: fail-fast: false matrix: - os: [ubuntu-latest, macos-latest] - # os: [ubuntu-latest, macos-latest, windows-latest] + os: [ubuntu-latest, macos-latest, windows-latest] # Is it a draft Pull Request (true or false)? isDraft: - ${{ github.event.pull_request.draft }}