Fix the failing tests for the updated gravimetric grids#4367
Merged
Conversation
Specifically the `earth_faa`, `earth_ndefl`, `earth_edefl` and `earth_vgg` grids. Xref GenericMappingTools/gmtserver-admin#291
Member
|
Out of curiosity: what is the main goal of these tests? |
Member
Author
|
Yes, we're just checking that the function runs ok, and the grids returns the expected values (no NaNs, etc). It helps when we do major refactoring, to ensure nothing goes wrong. |
Member
|
It sounds to me that you could use the static server instead. This is its readme file: Right now it doesn't have any gravimetric data, but I think we could add it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Specifically the
earth_faa,earth_faaerror,earth_ndefl,earth_edeflandearth_vgggrids. Xref GenericMappingTools/gmtserver-admin#291Fixes #
Preview:
Guidelines
Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash command is:
/format: automatically format and lint the code