pygmt.grdproject: Raise an exception when both 'unit' and 'scaling' are given#4371
Merged
seisman merged 7 commits intoJan 29, 2026
Merged
Conversation
This adds a check to see if 'unit' and 'scaling' are not both set, as the method cannot accept both inputs.
…rdproject.py. This adds input validation for grdproject, as there is no check for both 'unit' and 'scaling'. It adds an associated test in test_grdproject.py.
Contributor
Author
|
I don't understand why, but the test including both |
seisman
reviewed
Jan 27, 2026
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
seisman
reviewed
Jan 27, 2026
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
seisman
changed the title
seisman
added
maintenance
seisman
added
the
final review call
seisman
approved these changes
Jan 28, 2026
seisman
removed
the
final review call
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documentation for grdproject states that it cannot have both
unitandscalingset. This adds input validation and a test for it.Closes #4334