-
Notifications
You must be signed in to change notification settings - Fork 245
pygmt.project: Add input validation for geometry parameters #4415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 8 commits
595af10
e978a20
320664e
c06e318
4de1f58
7b3ade6
036982e
c511e4d
d5cc70f
f96b1f8
7bdf6a1
242f63c
ec0bf74
5e7b3e8
0f5bafd
48acc7c
3abedee
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -90,3 +90,19 @@ def test_project_incorrect_parameters(): | |
| with pytest.raises(GMTParameterError): | ||
| # Using `generate` with `convention` | ||
| project(center=[0, -1], generate=0.5, convention="xypqrsz") | ||
|
|
||
|
|
||
| def test_project_geometry_definition_validation(dataframe): | ||
| """ | ||
| Validate input validation for mutually | ||
| exclusive projection geometry parameters. | ||
|
seisman marked this conversation as resolved.
Outdated
|
||
| """ | ||
| with pytest.raises(GMTParameterError): | ||
| project( | ||
| center=[0, -1], | ||
| generate=0.5, | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. When
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The way I read the docs, the it just says that |
||
| data=dataframe, | ||
| endpoint=[0, 1], | ||
| azimuth=45, | ||
| pole=[0, 90], | ||
| ) | ||
|
willschlitzer marked this conversation as resolved.
Outdated
|
||
Uh oh!
There was an error while loading. Please reload this page.