Skip to content

fix: correct paths in genesis.cjs to enable project-genie continuous building#76

Draft
Igor Holt (igor-holt) wants to merge 4 commits into
mainfrom
fix-genesis-genie-paths-7033094089729547713
Draft

fix: correct paths in genesis.cjs to enable project-genie continuous building#76
Igor Holt (igor-holt) wants to merge 4 commits into
mainfrom
fix-genesis-genie-paths-7033094089729547713

Conversation

@igor-holt
Copy link
Copy Markdown
Member

This commit fixes the file paths in scripts/genesis.cjs that are used by the project-genie PM2 process.

  1. Updates the body path to generate components in yennefer-observatory/src/components/mutations instead of the broken generated directory, allowing Observatory.jsx to dynamically load the generated mutations.
  2. Updates the journal path to properly write logs to logs/genesis_journal.jsonl.
  3. Adds logic to dynamically create the logs directory if it does not already exist, ensuring the background service doesn't crash on writing the log.

These changes properly implement the live and continuous building of Yennefer components (project-genie).


PR created automatically by Jules for task 7033094089729547713 started by Igor Holt (@igor-holt)

…genie

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Apr 25, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
❌ Deployment failed
View logs
yennefer c6763b1 Apr 25 2026, 07:53 AM

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the body and journal paths in scripts/genesis.cjs and adds logic to ensure the log directory exists. Feedback identifies a missing 'fs' module import that would lead to a ReferenceError and suggests simplifying the directory creation by removing a redundant existence check.

Comment thread scripts/genesis.cjs
@@ -10,10 +10,16 @@ const path = require('path');
const PATHS = {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The fs module is used on lines 19-20 but is not imported in this file. This will result in a ReferenceError when the script attempts to create the logs directory. Please add the fs requirement at the top of the file.

const fs = require('fs');
const PATHS = {

Comment thread scripts/genesis.cjs
Comment on lines +19 to +21
if (!fs.existsSync(logDir)) {
fs.mkdirSync(logDir, { recursive: true });
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The if (!fs.existsSync(logDir)) check is redundant when using fs.mkdirSync with the recursive: true option. The recursive option ensures the operation is idempotent and does not throw an error if the directory already exists, simplifying the code.

fs.mkdirSync(logDir, { recursive: true });

Igor Holt (igor-holt) and others added 3 commits April 25, 2026 07:36
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
…ailure

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant