fix: correct paths in genesis.cjs to enable project-genie continuous building#76
fix: correct paths in genesis.cjs to enable project-genie continuous building#76Igor Holt (igor-holt) wants to merge 4 commits into
Conversation
…genie Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
yennefer | c6763b1 | Apr 25 2026, 07:53 AM |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the body and journal paths in scripts/genesis.cjs and adds logic to ensure the log directory exists. Feedback identifies a missing 'fs' module import that would lead to a ReferenceError and suggests simplifying the directory creation by removing a redundant existence check.
| @@ -10,10 +10,16 @@ const path = require('path'); | |||
| const PATHS = { | |||
There was a problem hiding this comment.
The fs module is used on lines 19-20 but is not imported in this file. This will result in a ReferenceError when the script attempts to create the logs directory. Please add the fs requirement at the top of the file.
const fs = require('fs');
const PATHS = {
| if (!fs.existsSync(logDir)) { | ||
| fs.mkdirSync(logDir, { recursive: true }); | ||
| } |
There was a problem hiding this comment.
The if (!fs.existsSync(logDir)) check is redundant when using fs.mkdirSync with the recursive: true option. The recursive option ensures the operation is idempotent and does not throw an error if the directory already exists, simplifying the code.
fs.mkdirSync(logDir, { recursive: true });
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
…ailure Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
1 participant
This commit fixes the file paths in
scripts/genesis.cjsthat are used by theproject-geniePM2 process.bodypath to generate components inyennefer-observatory/src/components/mutationsinstead of the brokengenerateddirectory, allowingObservatory.jsxto dynamically load the generated mutations.journalpath to properly write logs tologs/genesis_journal.jsonl.logsdirectory if it does not already exist, ensuring the background service doesn't crash on writing the log.These changes properly implement the live and continuous building of Yennefer components (project-genie).
PR created automatically by Jules for task 7033094089729547713 started by Igor Holt (@igor-holt)