Skip to content

⚡ Optimize JSON serialization and explicit UTF-8 encoding #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Igor Holt (igor-holt) wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

⚡ Optimize JSON serialization and explicit UTF-8 encoding #111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions simple_seismic_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,10 +109,10 @@ def do_GET(self):

def send_json(self, data):
self.send_response(200)
self.send_header('Content-Type', 'application/json')
self.send_header('Content-Type', 'application/json; charset=utf-8')
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The application/json media type does not define a charset parameter according to RFC 8259 Section 11. Since JSON is required to be encoded as UTF-8 by default, adding ; charset=utf-8 is redundant and can occasionally lead to compatibility issues with strict HTTP clients that do not expect parameters on this media type.

Suggested change
self.send_header('Content-Type', 'application/json; charset=utf-8')
self.send_header('Content-Type', 'application/json')

self.send_header('Access-Control-Allow-Origin', '*')
self.end_headers()
self.wfile.write(json.dumps(data, separators=(',', ':')).encode())
self.wfile.write(json.dumps(data, separators=(',', ':')).encode('utf-8'))
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To fully realize the benefits of UTF-8 encoding and minimize payload size for non-ASCII characters (as intended by this PR), consider adding ensure_ascii=False to the json.dumps call. By default, json.dumps escapes non-ASCII characters using Unicode escape sequences (e.g., \uXXXX), which increases the response size. Additionally, .encode('utf-8') is the default behavior in Python 3 and is redundant.

Suggested change
self.wfile.write(json.dumps(data, separators=(',', ':')).encode('utf-8'))
self.wfile.write(json.dumps(data, separators=(',', ':'), ensure_ascii=False).encode())


def log_message(self, format, *args):
"""Override to customize logging"""
Expand Down
Loading