Skip to content

⚡ Optimize JSON serialization to eliminate indentation #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Igor Holt (igor-holt) wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

⚡ Optimize JSON serialization to eliminate indentation #121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions simple_seismic_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
Uses Python's built-in http.server module
"""

from http.server import HTTPServer, BaseHTTPRequestHandler, ThreadingHTTPServer
from http.server import HTTPServer, BaseHTTPRequestHandler
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The ThreadingHTTPServer class was removed from the imports, but it is still used on line 130 to instantiate the server. This will cause a NameError at runtime, preventing the server from starting.

Suggested change
from http.server import HTTPServer, BaseHTTPRequestHandler
from http.server import HTTPServer, BaseHTTPRequestHandler, ThreadingHTTPServer

import json
from datetime import datetime
import time
Expand Down Expand Up @@ -109,10 +109,10 @@ def do_GET(self):

def send_json(self, data):
self.send_response(200)
self.send_header('Content-Type', 'application/json')
self.send_header('Content-Type', 'application/json; charset=utf-8')
self.send_header('Access-Control-Allow-Origin', '*')
self.end_headers()
self.wfile.write(json.dumps(data, separators=(',', ':')).encode())
self.wfile.write(json.dumps(data, separators=(',', ':')).encode('utf-8'))

def log_message(self, format, *args):
"""Override to customize logging"""
Expand Down
Loading