Skip to content

Commit 6df1f03

Browse files
Milotrinceclaude
andcommitted
Rename SolverContactProbeSensorOptionsMixin -> FilterableTactileProbeSensorOptionsMixin
The mixin's only contribution over TactileProbeSensorOptionsMixin is filter_link_idx (+ its validation); nothing "solver-contact" specific lives in it - that's in the sensor implementations. Name it for what it adds: the subset of tactile probes that support counterpart-link contact filtering. The point-cloud probes (Elastomer/Proximity) intentionally stay unfiltered - they already scope via track_link_idx (an allowlist), the dual of filter_link_idx. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 6411377 commit 6df1f03

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

genesis/options/sensors/tactile.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ class TactileProbeSensorOptionsMixin(ProbeSensorOptionsMixin[SensorT]):
6161
debug_contact_color: UnitIntervalVec4Type = (1.0, 0.2, 0.0, 0.8)
6262

6363

64-
class SolverContactProbeSensorOptionsMixin(TactileProbeSensorOptionsMixin[SensorT]):
64+
class FilterableTactileProbeSensorOptionsMixin(TactileProbeSensorOptionsMixin[SensorT]):
6565
"""
6666
Options for tactile probe sensors that resolve depth against the physics solver's active contact pairs (as
6767
opposed to a sampled point cloud), and can therefore scope which contacts count by the counterpart link.
@@ -107,7 +107,7 @@ class PointCloudTactileSensorMixin(TactileProbeSensorOptionsMixin[SensorT]):
107107
class ContactProbe(
108108
RigidSensorOptionsMixin["ContactProbeSensor"],
109109
SimpleSensorOptions["ContactProbeSensor"],
110-
SolverContactProbeSensorOptionsMixin["ContactProbeSensor"],
110+
FilterableTactileProbeSensorOptionsMixin["ContactProbeSensor"],
111111
):
112112
"""
113113
Returns boolean contact per probe based on the contact depth threshold.
@@ -124,7 +124,7 @@ class ContactProbe(
124124
class ContactDepthProbe(
125125
RigidSensorOptionsMixin["ContactDepthProbeSensor"],
126126
SimpleSensorOptions["ContactDepthProbeSensor"],
127-
SolverContactProbeSensorOptionsMixin["ContactDepthProbeSensor"],
127+
FilterableTactileProbeSensorOptionsMixin["ContactDepthProbeSensor"],
128128
):
129129
"""
130130
Returns contact depth in meters per probe.
@@ -134,7 +134,7 @@ class ContactDepthProbe(
134134
class KinematicTaxel(
135135
RigidSensorOptionsMixin["KinematicTaxelSensor"],
136136
SimpleSensorOptions["KinematicTaxelSensor"],
137-
SolverContactProbeSensorOptionsMixin["KinematicTaxelSensor"],
137+
FilterableTactileProbeSensorOptionsMixin["KinematicTaxelSensor"],
138138
ProbesWithNormalSensorOptionsMixin["KinematicTaxelSensor"],
139139
):
140140
"""

0 commit comments

Comments
 (0)