Smoke-test that pinned tools resolve to runnable binaries#7
Merged
Conversation
- proto reports a wrong exe-path as a successful install and only fails when the dangling binary is used, so the install matrix passed despite a broken shellcheck plugin - add scripts/smoke-test.sh: for every tool in .prototools, assert proto bin resolves and the binary runs - derive the tool list from the [plugins] table via the pinned taplo so new plugins are covered with no edit here - run the script in the existing per-platform install job Signed-off-by: Jean-Baptiste Louazel <jb.louazel@genesis-ai.company>
Collaborator
Author
|
Will succeed when #6 is merged |
pylaligand
approved these changes
Jun 23, 2026
- proto run taplo emits CRLF-terminated JSON under Git Bash, leaving a trailing carriage return on every tool name after jq, so proto bin failed to resolve all tools except the alphabetically last one - pipe the tool list through tr -d '\r' before iterating Signed-off-by: Jean-Baptiste Louazel <jb.louazel@genesis-ai.company>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
proto reports a wrong exe-path as a successful install and only fails when the dangling binary is actually used, so the install matrix went green even though the shellcheck plugin produced a broken symlink. I added scripts/smoke-test.sh, which asserts that every tool in .prototools resolves via proto bin and runs; the existing per-platform install job now executes it. The tool list is read from the [plugins] table with the pinned taplo, so new plugins are covered without editing the script.