[Fixup] clang-tidy: rename MetalCommandList::flush_pending_encoder_ to drop trailing underscore + add override on KernelLauncher destructors

Author: duburcqa

quadrants/rhi/metal/metal_device.h

@@ -422,7 +422,7 @@ class MetalCommandList final : public CommandList {
   // Silicon's M-series GPUs costs ~700 us of inter-dispatch gap (encoder teardown plus re-bind state), and Metal's
   // `dispatchType=Serial` already gives the same per-dispatch ordering inside a single encoder, so coalescing into one
   // encoder is semantics-preserving and shaves the gap to driver-scheduling overhead. The encoder is opened lazily on
-  // the first `dispatch()` call and torn down via `flush_pending_encoder_` before any encoder-incompatible op
+  // the first `dispatch()` call and torn down via `flush_pending_encoder` before any encoder-incompatible op
   // (`buffer_copy`, `buffer_fill`, `begin_renderpass`) and before `finalize()` returns the cmdbuf to the stream for
   // commit. Set of physical buffers already passed through `useResource:` in this encoder lifetime is tracked alongside
   // so we don't issue redundant `useResource:` calls inside one encoder. Initialised to `nullptr` (the C++ form of
@@ -431,7 +431,7 @@ class MetalCommandList final : public CommandList {
   // `nullptr` is a valid initialiser for both.
   MTLComputeCommandEncoder_id current_compute_encoder_{nullptr};
   std::unordered_set<uint64_t> compute_encoder_resident_alloc_ids_;
-  void flush_pending_encoder_();
+  void flush_pending_encoder();
 };
 
 class MetalStream final : public Stream {

quadrants/rhi/metal/metal_device.mm

@@ -413,7 +413,7 @@
 }
 
 MetalCommandList::~MetalCommandList() {
-  flush_pending_encoder_();
+  flush_pending_encoder();
   [cmdbuf_ release];
 }
 
@@ -422,7 +422,7 @@
 // returned for commit, so a long chain of `dispatch()` calls collapses to a
 // single MTLComputeCommandEncoder while incompatible ops still observe the
 // right per-encoder boundary that Metal's hazard tracking relies on.
-void MetalCommandList::flush_pending_encoder_() {
+void MetalCommandList::flush_pending_encoder() {
   if (current_compute_encoder_ != nil) {
     [current_compute_encoder_ endEncoding];
     [current_compute_encoder_ release];
@@ -487,7 +487,7 @@
 
 void MetalCommandList::buffer_copy(DevicePtr dst, DevicePtr src,
                                    size_t size) noexcept {
-  flush_pending_encoder_();
+  flush_pending_encoder();
   const MetalMemory &src_memory = device_->get_memory(src.alloc_id);
   const MetalMemory &dst_memory = device_->get_memory(dst.alloc_id);
 
@@ -515,7 +515,7 @@
 void MetalCommandList::buffer_fill(DevicePtr ptr, size_t size,
                                    uint32_t data) noexcept {
   RHI_ASSERT(data == 0);
-  flush_pending_encoder_();
+  flush_pending_encoder();
 
   const MetalMemory &memory = device_->get_memory(ptr.alloc_id);
 
@@ -555,15 +555,15 @@
     // so per-dispatch ordering inside one encoder is the same as separate
     // encoders, but we save the ~700 us of encoder-end / encoder-begin gap that
     // the Metal System Trace surfaces between every quadrants dispatch. The
-    // encoder is torn down by `flush_pending_encoder_` whenever an
+    // encoder is torn down by `flush_pending_encoder` whenever an
     // encoder-incompatible op (blit / render / cmdbuf finalize) needs to start.
     if (current_compute_encoder_ == nullptr) {
       // `[cmdbuf_ computeCommandEncoder]` returns an autoreleased encoder.
       // Retain it so the encoder survives past the enclosing `@autoreleasepool`
       // drain into the next `dispatch()` call; without this the autoreleased
       // encoder is freed before we end it, and Metal's
       // `_MTLCommandEncoder dealloc` asserts "Command encoder released without
-      // endEncoding". Released by `flush_pending_encoder_` after `endEncoding`.
+      // endEncoding". Released by `flush_pending_encoder` after `endEncoding`.
       current_compute_encoder_ = [[cmdbuf_ computeCommandEncoder] retain];
     }
     MTLComputeCommandEncoder_id encoder = current_compute_encoder_;
@@ -621,7 +621,7 @@
                                         std::vector<float> *clear_colors,
                                         DeviceAllocation *depth_attachment,
                                         bool depth_clear) {
-  flush_pending_encoder_();
+  flush_pending_encoder();
   current_renderpass_details_.clear_depth = depth_clear;
 
   int rendertarget_height = 0;
@@ -771,7 +771,7 @@
 void MetalCommandList::set_renderpass_active() { is_renderpass_active_ = true; }
 
 MTLRenderCommandEncoder_id MetalCommandList::pre_draw_setup() {
-  flush_pending_encoder_();
+  flush_pending_encoder();
   const RasterParams *raster_params = current_pipeline_->raster_params();
 
   MTLRenderPassDescriptor *rpd = create_render_pass_desc(
@@ -983,7 +983,7 @@
   buffer_image_copy_params_to_mtl(params, src_buf.offset,
                                   dst_image.mtl_texture(), &mtl_params);
 
-  flush_pending_encoder_();
+  flush_pending_encoder();
   @autoreleasepool {
     MTLBlitCommandEncoder_id encoder = [cmdbuf_ blitCommandEncoder];
     [encoder copyFromBuffer:src_buffer.mtl_buffer()
@@ -1011,7 +1011,7 @@
   buffer_image_copy_params_to_mtl(params, dst_buf.offset,
                                   src_image.mtl_texture(), &mtl_params);
 
-  flush_pending_encoder_();
+  flush_pending_encoder();
   @autoreleasepool {
     MTLBlitCommandEncoder_id encoder = [cmdbuf_ blitCommandEncoder];
     [encoder copyFromTexture:src_image.mtl_texture()
@@ -1036,7 +1036,7 @@
   const MetalImage &src_image = device_->get_image(src_img.alloc_id);
   const MetalImage &dst_image = device_->get_image(dst_img.alloc_id);
 
-  flush_pending_encoder_();
+  flush_pending_encoder();
   @autoreleasepool {
     MTLBlitCommandEncoder_id encoder = [cmdbuf_ blitCommandEncoder];
     [encoder
@@ -1062,7 +1062,7 @@
 }
 
 MTLCommandBuffer_id MetalCommandList::finalize() {
-  flush_pending_encoder_();
+  flush_pending_encoder();
   return cmdbuf_;
 }
 

quadrants/runtime/amdgpu/kernel_launcher.h

@@ -52,7 +52,7 @@ class KernelLauncher : public LLVM::KernelLauncher {
   std::vector<Context> contexts_;
 
  public:
-  ~KernelLauncher();
+  ~KernelLauncher() override;
 };
 
 }  // namespace amdgpu

quadrants/runtime/cuda/kernel_launcher.h

@@ -65,7 +65,7 @@ class KernelLauncher : public LLVM::KernelLauncher {
   std::size_t persistent_result_buffer_capacity_{0};
 
  public:
-  ~KernelLauncher();
+  ~KernelLauncher() override;
 };
 
 }  // namespace cuda