[Fixup] Route ndarray + snode-accessor host reads/writes through synchronize_and_assert

Author: duburcqa

quadrants/program/ndarray.cpp

@@ -132,7 +132,7 @@ std::size_t Ndarray::get_nelement() const {
 }
 
 TypedConstant Ndarray::read(const std::vector<int> &I) const {
-  prog_->synchronize();
+  prog_->synchronize_and_assert();
   size_t index = flatten_index(total_shape_, I);
   size_t size = data_type_size(get_element_data_type());
   quadrants::lang::Device::AllocParams alloc_params;
@@ -184,7 +184,7 @@ void Ndarray::write(const std::vector<int> &I, TypedConstant val) const {
   staging_buf_->device->unmap(*staging_buf_);
   staging_buf_->device->memcpy_internal(this->ndarray_alloc_.get_ptr(index * size_), staging_buf_->get_ptr(), size_);
 
-  prog_->synchronize();
+  prog_->synchronize_and_assert();
 }
 
 int64 Ndarray::read_int(const std::vector<int> &i) {

quadrants/program/snode_rw_accessors_bank.cpp

@@ -43,7 +43,7 @@ void SNodeRwAccessorsBank::Accessors::write_float(const std::vector<int> &I, flo
   auto launch_ctx = writer_->make_launch_context();
   set_kernel_args(I, snode_->num_active_indices, &launch_ctx);
   launch_ctx.set_arg_float(snode_->num_active_indices, val);
-  prog_->synchronize();
+  prog_->synchronize_and_assert();
   const auto &compiled_kernel_data = get_or_compile(kernels_.writer_compiled, prog_, *writer_);
   prog_->launch_kernel(compiled_kernel_data, launch_ctx);
   // Drives invalidation of the SPIR-V per-task adstack metadata cache: a runtime adstack bound that
@@ -54,7 +54,7 @@ void SNodeRwAccessorsBank::Accessors::write_float(const std::vector<int> &I, flo
 }
 
 float64 SNodeRwAccessorsBank::Accessors::read_float(const std::vector<int> &I) {
-  prog_->synchronize();
+  prog_->synchronize_and_assert();
   auto launch_ctx = reader_->make_launch_context();
   set_kernel_args(I, snode_->num_active_indices, &launch_ctx);
   const auto &compiled_kernel_data = get_or_compile(kernels_.reader_compiled, prog_, *reader_);
@@ -68,7 +68,7 @@ void SNodeRwAccessorsBank::Accessors::write_int(const std::vector<int> &I, int64
   auto launch_ctx = writer_->make_launch_context();
   set_kernel_args(I, snode_->num_active_indices, &launch_ctx);
   launch_ctx.set_arg_int(snode_->num_active_indices, val);
-  prog_->synchronize();
+  prog_->synchronize_and_assert();
   const auto &compiled_kernel_data = get_or_compile(kernels_.writer_compiled, prog_, *writer_);
   prog_->launch_kernel(compiled_kernel_data, launch_ctx);
   prog_->adstack_cache().bump_snode_write_gen(snode_->id);
@@ -79,14 +79,14 @@ void SNodeRwAccessorsBank::Accessors::write_uint(const std::vector<int> &I, uint
   auto launch_ctx = writer_->make_launch_context();
   set_kernel_args(I, snode_->num_active_indices, &launch_ctx);
   launch_ctx.set_arg_uint(snode_->num_active_indices, val);
-  prog_->synchronize();
+  prog_->synchronize_and_assert();
   const auto &compiled_kernel_data = get_or_compile(kernels_.writer_compiled, prog_, *writer_);
   prog_->launch_kernel(compiled_kernel_data, launch_ctx);
   prog_->adstack_cache().bump_snode_write_gen(snode_->id);
 }
 
 int64 SNodeRwAccessorsBank::Accessors::read_int(const std::vector<int> &I) {
-  prog_->synchronize();
+  prog_->synchronize_and_assert();
   auto launch_ctx = reader_->make_launch_context();
   set_kernel_args(I, snode_->num_active_indices, &launch_ctx);
   const auto &compiled_kernel_data = get_or_compile(kernels_.reader_compiled, prog_, *reader_);
@@ -96,7 +96,7 @@ int64 SNodeRwAccessorsBank::Accessors::read_int(const std::vector<int> &I) {
 }
 
 uint64 SNodeRwAccessorsBank::Accessors::read_uint(const std::vector<int> &I) {
-  prog_->synchronize();
+  prog_->synchronize_and_assert();
   auto launch_ctx = reader_->make_launch_context();
   set_kernel_args(I, snode_->num_active_indices, &launch_ctx);
   const auto &compiled_kernel_data = get_or_compile(kernels_.reader_compiled, prog_, *reader_);