[Misc] Remove host-side memory monitoring functionality#761
Conversation
Removes the C++ memory monitor (memory_usage_monitor.{h,cpp}) and its
`start_memory_monitoring` Python binding. This was a debug-only utility with no
callers in the codebase, and its implementation embedded a Python interpreter
(pybind11/embed.h) + psutil, which is awkward to maintain (and unsupported under
nanobind). The QUADRANTS_PYBIND_SOURCE glob picks up python/*.cpp, so no CMake
change is needed.
psutil is left in place: it is still used independently by the CI build scripts
and tests/python/test_memory.py.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1fb052c09c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| m.def("print_profile_info", [&]() { Profiling::get_instance().print_profile_info(); }); | ||
| m.def("clear_profile_info", [&]() { Profiling::get_instance().clear_profile_info(); }); | ||
| m.def("start_memory_monitoring", start_memory_monitoring); | ||
| m.def("get_repo_dir", get_repo_dir); |
There was a problem hiding this comment.
For users who call the exported qd._lib.core.start_memory_monitoring binding, this deletion changes the Python API by turning that call into an AttributeError, but the commit only removes C++ files and does not add any docs/ migration/removal note. The repository AGENTS.md explicitly asks review agents to flag public API or usage changes without corresponding user-facing docs, so this removal should be documented or otherwise called out for users.
Useful? React with 👍 / 👎.
1 participant
Removes the C++ memory monitor (memory_usage_monitor.{h,cpp}) and its
start_memory_monitoringPython binding. This was a debug-only utility with no callers in the codebase, and its implementation embedded a Python interpreter (pybind11/embed.h) + psutil, which is awkward to maintain (and unsupported under nanobind). The QUADRANTS_PYBIND_SOURCE glob picks up python/*.cpp, so no CMake change is needed.psutil is left in place: it is still used independently by the CI build scripts and tests/python/test_memory.py.
Issue: #
Brief Summary
copilot:summary
Walkthrough
copilot:walkthrough