[Atomics] Migrate metal to use native float atomics#787
Closed
hughperkins wants to merge 4 commits into
Closed
Conversation
The Jan 2023 FIXME never had a repro: FEM99/FEM128 were GUI demos removed from the tree, and native float atomics were never enabled on the SPIR-V Metal path. Add QD_METAL_NATIVE_FLOAT_ATOMICS=1 opt-in, a headless FEM99 numerical test, and a macos-15 A/B workflow (CAS default vs native).
…p MSL on native abort Round 1 showed CAS pass / native Abort trap:6 on first FEM99 kernel. Isolate which test crashes and capture SPIRV-Cross MSL for OpAtomicFAddEXT.
…rior wheel Even test_ad_reduce (N=16) Abort-traps with QD_METAL_NATIVE_FLOAT_ATOMICS=1. Add metal_native_atomic_min.py and dump SPIRV-Cross MSL. Skip rebuild when the previous workflow wheel is reusable.
OpAtomicFAddEXT lowers to atomic_float, which newLibraryWithSource rejects
under the default/MSL-2.x language version ("unknown type name 'atomic_float'"),
then a nil MTLFunction hard-aborts. Bump SPIRV-Cross + MTLCompileOptions to 3.0
when the float-atomic caps are set; nil-check before pipeline creation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #
Brief Summary
copilot:summary
Walkthrough
copilot:walkthrough