fix: Resolve orphan rules and trait bounds in rustorch-pytorch

Author: “thucydides”

rustorch-pytorch/src/lib.rs

@@ -1,8 +1,7 @@
-use rustorch_core::{Tensor, Storage};
+use rustorch_core::Tensor;
 use tch::{self, Kind, Device as TchDevice};
-use anyhow::{Result, Context};
+use anyhow::Result;
 use std::path::Path;
-use std::borrow::Borrow;
 
 pub struct PyTorchAdapter;
 
@@ -31,10 +30,10 @@ impl PyTorchAdapter {
             // Cast to float if not
             // For now, we only support f32 in RusTorch
             let float_tensor = cpu_tensor.to_kind(Kind::Float);
-            let data: Vec<f32> = Vec::<f32>::from(&float_tensor);
+            let data: Vec<f32> = float_tensor.into();
             Ok(Tensor::new(&data, &size))
         } else {
-            let data: Vec<f32> = Vec::<f32>::from(&cpu_tensor);
+            let data: Vec<f32> = cpu_tensor.into();
             Ok(Tensor::new(&data, &size))
         }
     }
@@ -104,21 +103,6 @@ pub mod ops {
     }
 }
 
-// Implement From traits for convenience
-impl From<&Tensor> for tch::Tensor {
-    fn from(tensor: &Tensor) -> Self {
-        PyTorchAdapter::to_torch(tensor)
-    }
-}
-
-impl TryFrom<&tch::Tensor> for Tensor {
-    type Error = anyhow::Error;
-
-    fn try_from(tensor: &tch::Tensor) -> Result<Self> {
-        PyTorchAdapter::from_torch(tensor)
-    }
-}
-
 #[cfg(test)]
 mod tests {
     use super::*;

target/.rustc_info.json

@@ -1 +1 @@
-{"rustc_fingerprint":18217616115906611278,"outputs":{"7971740275564407648":{"success":true,"status":"","code":0,"stdout":"___.exe\nlib___.rlib\n___.dll\n___.dll\nlib___.a\n___.dll\nC:\\Users\\25919\\.rustup\\toolchains\\stable-x86_64-pc-windows-gnu\noff\n___\ndebug_assertions\npanic=\"unwind\"\nproc_macro\ntarget_abi=\"\"\ntarget_arch=\"x86_64\"\ntarget_endian=\"little\"\ntarget_env=\"gnu\"\ntarget_family=\"windows\"\ntarget_feature=\"cmpxchg16b\"\ntarget_feature=\"fxsr\"\ntarget_feature=\"sse\"\ntarget_feature=\"sse2\"\ntarget_feature=\"sse3\"\ntarget_has_atomic=\"128\"\ntarget_has_atomic=\"16\"\ntarget_has_atomic=\"32\"\ntarget_has_atomic=\"64\"\ntarget_has_atomic=\"8\"\ntarget_has_atomic=\"ptr\"\ntarget_os=\"windows\"\ntarget_pointer_width=\"64\"\ntarget_vendor=\"pc\"\nwindows\n","stderr":""},"17747080675513052775":{"success":true,"status":"","code":0,"stdout":"rustc 1.94.0 (4a4ef493e 2026-03-02)\nbinary: rustc\ncommit-hash: 4a4ef493e3a1488c6e321570238084b38948f6db\ncommit-date: 2026-03-02\nhost: x86_64-pc-windows-gnu\nrelease: 1.94.0\nLLVM version: 21.1.8\n","stderr":""}},"successes":{}}
+{"rustc_fingerprint":5931207633046374884,"outputs":{"7971740275564407648":{"success":true,"status":"","code":0,"stdout":"___.exe\nlib___.rlib\n___.dll\n___.dll\n___.lib\n___.dll\nC:\\Users\\25919\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\npacked\n___\ndebug_assertions\npanic=\"unwind\"\nproc_macro\ntarget_abi=\"\"\ntarget_arch=\"x86_64\"\ntarget_endian=\"little\"\ntarget_env=\"msvc\"\ntarget_family=\"windows\"\ntarget_feature=\"cmpxchg16b\"\ntarget_feature=\"fxsr\"\ntarget_feature=\"sse\"\ntarget_feature=\"sse2\"\ntarget_feature=\"sse3\"\ntarget_has_atomic=\"128\"\ntarget_has_atomic=\"16\"\ntarget_has_atomic=\"32\"\ntarget_has_atomic=\"64\"\ntarget_has_atomic=\"8\"\ntarget_has_atomic=\"ptr\"\ntarget_os=\"windows\"\ntarget_pointer_width=\"64\"\ntarget_vendor=\"pc\"\nwindows\n","stderr":""},"17747080675513052775":{"success":true,"status":"","code":0,"stdout":"rustc 1.94.0 (4a4ef493e 2026-03-02)\nbinary: rustc\ncommit-hash: 4a4ef493e3a1488c6e321570238084b38948f6db\ncommit-date: 2026-03-02\nhost: x86_64-pc-windows-msvc\nrelease: 1.94.0\nLLVM version: 21.1.8\n","stderr":""}},"successes":{}}