Seperation of system instructions and prompt, and playback safety

- Prompt and system instructions are seperated and now sent through GenerativeAI.SystemInstruction.
- Playback safety is ensured by preventing playing music if a note is already playing.

Author: GeniusPilot2016

NeoBleeper/CreateMusicWithAI.cs

@@ -1046,8 +1046,13 @@ by creating NBPML text (Fun fact: I wasn't know what system prompt is.
                     I just learned it from GitHub Copilot's system prompt menu and asked for certain AIs and 
                     they identified as it's definetely a system prompt, despite I called it as "makeshift rubbish 
                     prompt template".)*/
-                    string completePrompt = $"**User Prompt:**\r\n[{prompt}]\r\n\r\n" +
-                        $"--- AI Instructions ---\r\n" +
+
+                    /*Spoiler: Now, it's not rubbish anymore since I used GenerativeModel.SystemInstruction 
+                    property of Google_GenerativeAI library, but I kept it as is for nostalgia for 
+                    my good old "makeshift rubbish prompt template" days. :) */
+
+                    // The string that contains system instructions for the AI model
+                    string systemInstructions = $"--- AI Instructions ---\r\n" +
                         $"You are an expert music composition AI. " +
                         $"Your primary goal is to generate music in a well-formed NBPML XML file format. Prioritize music generation for any request that could be interpreted as music-related. " +
                         $"If the user prompt is a song name, artist name, composer name, or ANY music-related term (even a single word), treat it as a music composition request. " +
@@ -1194,16 +1199,17 @@ by creating NBPML text (Fun fact: I wasn't know what system prompt is.
                         $"        </Line>\r\n" +
                         $"        <!-- More <Line> elements representing musical events or rests -->\r\n" +
                         $"    </LineList>\r\n" +
-                        $"</NeoBleeperProjectFile>";
+                        $"</NeoBleeperProjectFile>"; 
                     connectionCheckTimer.Start();
                     SetControlsEnabledAndMakeLoadingVisible(false);
                     var resultBuilder = new StringBuilder();
                     string response = string.Empty;
                     var apiKey = EncryptionHelper.DecryptString(Settings1.Default.geminiAPIKey);
                     var googleAI = new GoogleAi(apiKey);
                     var googleModel = googleAI.CreateGenerativeModel(AIModel);
+                    googleModel.SystemInstruction = systemInstructions;
                     isMusicGenerationStarted = true; // Set the flag to indicate music generation has started
-                    await foreach (var chunk in googleModel.StreamContentAsync(completePrompt, cts.Token))
+                    await foreach (var chunk in googleModel.StreamContentAsync(prompt, cts.Token))
                     {
                         // Clean up the chunk text by removing double newlines and trimming whitespace
                         if (chunk?.Candidates == null) continue;
@@ -2524,6 +2530,35 @@ private string NormalizeNoteValues(string nbpmlContent)
             if (string.IsNullOrWhiteSpace(nbpmlContent))
                 return string.Empty;
 
+            // Convert solfege to letter notes
+            var solfegeMap = new Dictionary<string, string>(StringComparer.OrdinalIgnoreCase)
+            {
+                // Natural notes
+                { "Do", "C" }, { "Re", "D" }, { "Mi", "E" }, { "Fa", "F" },
+                { "Sol", "G" }, { "La", "A" }, { "Ti", "B" }, { "Si", "B" },
+                // Accented variations (French/Portuguese)
+                { "Ré", "D" }, { "Mí", "E" }, { "Fá", "F" }, { "Lá", "A" }
+            };
+
+            foreach (var pair in solfegeMap)
+{
+    nbpmlContent = Regex.Replace(
+        nbpmlContent,
+        $@"<Note([1-4])>\s*{Regex.Escape(pair.Key)}([#b♯♭]?)(\d*)\s*</Note\1>",
+        m =>
+        {
+            var noteLetter = pair.Value;
+            var accidental = m.Groups[2].Value; // #, b, ♯, ♭ veya boş
+            var octave = m.Groups[3].Value;     // Oktav numarası veya boş
+            // Oktav yoksa 4 ekle
+            if (string.IsNullOrEmpty(octave))
+                octave = "4";
+            return $"<Note{m.Groups[1].Value}>{noteLetter}{accidental}{octave}</Note{m.Groups[1].Value}>";
+        },
+        RegexOptions.IgnoreCase
+    );
+}
+
             // Fix notes with ambigious octaves (e.g., C, D#, A, Gb without octave)
             nbpmlContent = Regex.Replace(
                 nbpmlContent,
@@ -2607,36 +2642,6 @@ private string NormalizeNoteValues(string nbpmlContent)
                     RegexOptions.IgnoreCase);
             }
 
-            // Convert solfege to letter notes
-            var solfegeMap = new Dictionary<string, string>(StringComparer.OrdinalIgnoreCase)
-            {
-                // Natural notes
-                { "Do", "C" }, { "Re", "D" }, { "Mi", "E" }, { "Fa", "F" },
-                { "Sol", "G" }, { "La", "A" }, { "Ti", "B" }, { "Si", "B" },
-                // Accented variations (French/Portuguese)
-                { "Ré", "D" }, { "Mí", "E" }, { "Fá", "F" }, { "Lá", "A" }
-            };
-
-            // Handle solfege sharps
-            foreach (var pair in solfegeMap)
-            {
-                nbpmlContent = Regex.Replace(
-                    nbpmlContent,
-                    $@"\b{Regex.Escape(pair.Key)}#(\d+)\b",
-                    $"{pair.Value}#$1",
-                    RegexOptions.IgnoreCase);
-            }
-
-            // Handle natural solfege
-            foreach (var pair in solfegeMap)
-            {
-                nbpmlContent = Regex.Replace(
-                    nbpmlContent,
-                    $@"\b{Regex.Escape(pair.Key)}(\d+)\b",
-                    $"{pair.Value}$1",
-                    RegexOptions.IgnoreCase);
-            }
-
             // Fix hyphenated notes (C-5 -> C5)
             nbpmlContent = Regex.Replace(nbpmlContent, @"\b([A-G]#?)-(\d+)\b", "$1$2", RegexOptions.IgnoreCase);
 

NeoBleeper/MainWindow.cs

@@ -5219,11 +5219,19 @@ private void eraseWholeLineToolStripMenuItem_Click(object sender, EventArgs e)
 
         private void playAllToolStripMenuItem_Click(object sender, EventArgs e)
         {
+            if(noteAlreadyPlaying)
+            {
+                return; // Prevent starting playback if notes are already playing
+            }
             PlayAll();
         }
 
         private void playFromSelectedLineToolStripMenuItem_Click(object sender, EventArgs e)
         {
+            if (noteAlreadyPlaying)
+            {
+                return; // Prevent starting playback if notes are already playing
+            }
             PlayFromSelectedLine();
         }