Full percussion support in UI

- Percussion channel is named in all supported languages and instruments are now disabling if percussion channel is selected.

Author: GeniusPilot2016

NeoBleeper/SettingsWindow.cs

@@ -1447,9 +1447,18 @@ private void RefreshMidiOutputDevices()
                 label_channel.Enabled = true;
                 comboBox_midi_output_channel.SelectedIndex = TemporarySettings.MIDIDevices.MIDIOutputDeviceChannel;
                 comboBox_midi_output_channel.Enabled = true;
-                label_instrument.Enabled = true;
-                comboBox_midi_output_instrument.SelectedIndex = TemporarySettings.MIDIDevices.MIDIOutputInstrument;
-                comboBox_midi_output_instrument.Enabled = true;
+                if (TemporarySettings.MIDIDevices.MIDIOutputDeviceChannel != 9)
+                {
+                    label_instrument.Enabled = true;
+                    comboBox_midi_output_instrument.SelectedIndex = TemporarySettings.MIDIDevices.MIDIOutputInstrument;
+                    comboBox_midi_output_instrument.Enabled = true;
+                }
+                else
+                {
+                    label_instrument.Enabled = false;
+                    comboBox_midi_output_instrument.Enabled = false;
+                    comboBox_midi_output_instrument.SelectedIndex = -1; // Deselect instrument
+                }
             }
             else
             {
@@ -1521,19 +1530,47 @@ private void checkBox_use_midi_output_CheckedChanged(object sender, EventArgs e)
 
         private void comboBox_midi_output_devices_SelectedIndexChanged(object sender, EventArgs e)
         {
+            if(comboBox_midi_output_devices.SelectedIndex < 0)
+            {
+                return; // No device selected or deselected due to no available devices
+            }
             TemporarySettings.MIDIDevices.MIDIOutputDevice = comboBox_midi_output_devices.SelectedIndex;
             MIDIIOUtils.ChangeOutputDevice(TemporarySettings.MIDIDevices.MIDIOutputDevice);
             Logger.Log("MIDI output device selected: " + comboBox_midi_output_devices.SelectedItem.ToString(), Logger.LogTypes.Info);
         }
 
         private void comboBox_midi_output_channel_SelectedIndexChanged(object sender, EventArgs e)
         {
+            if(comboBox_midi_output_channel.SelectedIndex < 0)
+            {
+                return; // No channel selected or deselected due to no available devices
+            }
             TemporarySettings.MIDIDevices.MIDIOutputDeviceChannel = comboBox_midi_output_channel.SelectedIndex;
-            Logger.Log("MIDI output channel selected: " + comboBox_midi_output_channel.SelectedItem.ToString(), Logger.LogTypes.Info);
+            Logger.Log("MIDI output channel selected: Channel " + ((comboBox_midi_output_channel.SelectedIndex + 1) != 10 ?
+                (comboBox_midi_output_channel.SelectedIndex + 1).ToString() : 
+                (comboBox_midi_output_channel.SelectedIndex + 1).ToString() + " (Percussion)"), 
+                Logger.LogTypes.Info); // +1 to convert zero-based index to one-based channel number while logging
+            if (TemporarySettings.MIDIDevices.MIDIOutputDeviceChannel == 9) // Percussion  channel
+            {
+                label_instrument.Enabled = false; // Disable the label
+                comboBox_midi_output_instrument.Enabled = false; // Disable instrument selection
+                comboBox_midi_output_instrument.SelectedIndex = -1; // Deselect instrument
+                Logger.Log("Percussion or sound effects channel selected; instrument selection disabled.", Logger.LogTypes.Info);
+            }
+            else
+            {
+                label_instrument.Enabled = true; // Enable the label
+                comboBox_midi_output_instrument.SelectedIndex = TemporarySettings.MIDIDevices.MIDIOutputInstrument;
+                comboBox_midi_output_instrument.Enabled = true; // Enable instrument selection
+            }
         }
 
         private void comboBox_midi_output_instrument_SelectedIndexChanged(object sender, EventArgs e)
         {
+            if(comboBox_midi_output_instrument.SelectedIndex < 0)
+            {
+                return; // No instrument selected or deselected by percussion channel or no available devices
+            }
             TemporarySettings.MIDIDevices.MIDIOutputInstrument = comboBox_midi_output_instrument.SelectedIndex;
             MIDIIOUtils.ChangeInstrument(MIDIIOUtils._midiOut, TemporarySettings.MIDIDevices.MIDIOutputInstrument,
             TemporarySettings.MIDIDevices.MIDIOutputDeviceChannel);

NeoBleeper/SettingsWindow.de.resx

@@ -159,7 +159,7 @@
         AAEAAAD/////AQAAAAAAAAAMAgAAAEZTeXN0ZW0uV2luZG93cy5Gb3JtcywgQ3VsdHVyZT1uZXV0cmFs
         LCBQdWJsaWNLZXlUb2tlbj1iNzdhNWM1NjE5MzRlMDg5BQEAAAAmU3lzdGVtLldpbmRvd3MuRm9ybXMu
         SW1hZ2VMaXN0U3RyZWFtZXIBAAAABERhdGEHAgIAAAAJAwAAAA8DAAAApE0AAAJNU0Z0AUkBTAIBARIB
-        AAE4AQgBOAEIARIBAAESAQAE/wEhAQAI/wFCAU0BNgcAATYDAAEoAwABSAMAAVoDAAEBAQABIAUAAUAB
+        AAFIAQgBSAEIARIBAAESAQAE/wEhAQAI/wFCAU0BNgcAATYDAAEoAwABSAMAAVoDAAEBAQABIAUAAUAB
         Zf8A/wB0AAMiATECZgFfAeUEAvgAAlIBUQGkAfIB1AGbAf8B9QHeAbMB/wH1Ad4BswH/AfUB3gGzAf8B
         9QHeAbMB/wH1Ad4BswH/AfUB3gGzAf8B5wHIAaAB/wHnAcgBoAH/AecByAGgAf8B5wHIAaAB/wHnAcgB
         oAH/AecByAGgAf8B5wHIAaAB/wHZAYwBKQH/FAADNQFVBAABEAHHAf4B/wgAARABxwH+Af8EAAM1AVUI
@@ -1283,7 +1283,7 @@ möglicherweise nur als kostenpflichtiger Dienst verfügbar. Bitte stellen Sie s
     <value>Kanal 9</value>
   </data>
   <data name="comboBox_midi_output_channel.Items9" xml:space="preserve">
-    <value>Kanal 10</value>
+    <value>Kanal 10 (Schlagzeug)</value>
   </data>
   <data name="comboBox_midi_output_channel.Items10" xml:space="preserve">
     <value>Kanal 11</value>

NeoBleeper/SettingsWindow.es.resx

@@ -144,7 +144,7 @@
         AAEAAAD/////AQAAAAAAAAAMAgAAAEZTeXN0ZW0uV2luZG93cy5Gb3JtcywgQ3VsdHVyZT1uZXV0cmFs
         LCBQdWJsaWNLZXlUb2tlbj1iNzdhNWM1NjE5MzRlMDg5BQEAAAAmU3lzdGVtLldpbmRvd3MuRm9ybXMu
         SW1hZ2VMaXN0U3RyZWFtZXIBAAAABERhdGEHAgIAAAAJAwAAAA8DAAAApE0AAAJNU0Z0AUkBTAIBARIB
-        AAHMAQcBzAEHARIBAAESAQAE/wEhAQAI/wFCAU0BNgcAATYDAAEoAwABSAMAAVoDAAEBAQABIAUAAUAB
+        AAHcAQcB3AEHARIBAAESAQAE/wEhAQAI/wFCAU0BNgcAATYDAAEoAwABSAMAAVoDAAEBAQABIAUAAUAB
         Zf8A/wB0AAMiATECZgFfAeUEAvgAAlIBUQGkAfIB1AGbAf8B9QHeAbMB/wH1Ad4BswH/AfUB3gGzAf8B
         9QHeAbMB/wH1Ad4BswH/AfUB3gGzAf8B5wHIAaAB/wHnAcgBoAH/AecByAGgAf8B5wHIAaAB/wHnAcgB
         oAH/AecByAGgAf8B5wHIAaAB/wHZAYwBKQH/FAADNQFVBAABEAHHAf4B/wgAARABxwH+Af8EAAM1AVUI
@@ -1126,7 +1126,7 @@ como servicio de pago. Asegúrese de que su clave API corresponda a una cuenta d
     <value>Canal 9</value>
   </data>
   <data name="comboBox_midi_output_channel.Items9" xml:space="preserve">
-    <value>Canal 10</value>
+    <value>Canal 10 (Percusión)</value>
   </data>
   <data name="comboBox_midi_output_channel.Items10" xml:space="preserve">
     <value>Canal 11</value>