Bug fix in replacing note with length replace and improvement in MIDI file player

- The bug in replacing note with length replace that causes to not replace length when note and length is replaced same time.
- The MIDI file player is improved to reduce crackling sounds and inconsistencies.

Author: GeniusPilot2016

NeoBleeper/MIDIFilePlayer.cs

@@ -836,7 +836,7 @@ private async Task PlayMultipleNotesAsync(int[] frequencies, int duration, Cance
                         int currentNoteIndex = i;
                         HighlightNoteLabel(currentNoteIndex);
                         // Run the actual sound generation off the calling context but avoid spinning extra Task.Run loops.
-                        await Task.Run(() => NotePlayer.PlayNote(frequencies[currentNoteIndex], notePlayDuration), token);
+                        await Task.Run(() => NotePlayer.PlayNoteWithoutGap(frequencies[currentNoteIndex], notePlayDuration), token);
                         UnHighlightNoteLabel(currentNoteIndex);
 
                         int gap = Math.Max(0, timePerNote - notePlayDuration);
@@ -867,7 +867,7 @@ private async Task PlayMultipleNotesAsync(int[] frequencies, int duration, Cance
                             notePlayDuration = interval;
 
                         HighlightNoteLabel(noteIndex);
-                        await Task.Run(() => NotePlayer.PlayNote(frequencies[noteIndex], notePlayDuration), token);
+                        await Task.Run(() => NotePlayer.PlayNoteWithoutGap(frequencies[noteIndex], notePlayDuration), token);
                         UnHighlightNoteLabel(noteIndex);
 
                         // Wait until next note time (approximate)
@@ -1631,7 +1631,7 @@ private async Task ProcessCurrentFrame()
                 var frequencies = filteredNotes.Select(note => NoteToFrequency(note)).ToArray();
                 if (frequencies.Length == 1)
                 {
-                    await Task.Run(() => NotePlayer.PlayNote(frequencies[0], durationMsInt), token);
+                    await Task.Run(() => NotePlayer.PlayNoteWithoutGap(frequencies[0], durationMsInt), token);
                 }
                 else
                 {

NeoBleeper/MainWindow.cs

@@ -935,28 +935,28 @@ private void ReplaceNoteAndLengthOfLine(string note)
                 {
                     Line.note1 = note;
                     ReplaceLengthWithoutSavingToMemento();
-                    var replaceNoteCommand = new ReplaceNoteAndLengthCommand(listViewNotes, listViewNotes.SelectedItems[0].SubItems[0].Text, 1, note);
+                    var replaceNoteCommand = new ReplaceNoteAndLengthCommand(listViewNotes, Line.length, 1, note);
                     commandManager.ExecuteCommand(replaceNoteCommand);
                 }
                 if (add_as_note2.Checked == true)
                 {
                     Line.note2 = note;
                     ReplaceLengthWithoutSavingToMemento();
-                    var replaceNoteCommand = new ReplaceNoteAndLengthCommand(listViewNotes, listViewNotes.SelectedItems[0].SubItems[0].Text, 2, note);
+                    var replaceNoteCommand = new ReplaceNoteAndLengthCommand(listViewNotes, Line.length, 2, note);
                     commandManager.ExecuteCommand(replaceNoteCommand);
                 }
                 if (add_as_note3.Checked == true)
                 {
                     Line.note3 = note;
                     ReplaceLengthWithoutSavingToMemento();
-                    var replaceNoteCommand = new ReplaceNoteAndLengthCommand(listViewNotes, listViewNotes.SelectedItems[0].SubItems[0].Text, 3, note);
+                    var replaceNoteCommand = new ReplaceNoteAndLengthCommand(listViewNotes, Line.length, 3, note);
                     commandManager.ExecuteCommand(replaceNoteCommand);
                 }
                 if (add_as_note4.Checked == true)
                 {
                     Line.note4 = note;
                     ReplaceLengthWithoutSavingToMemento();
-                    var replaceNoteCommand = new ReplaceNoteAndLengthCommand(listViewNotes, listViewNotes.SelectedItems[0].SubItems[0].Text, 4, note);
+                    var replaceNoteCommand = new ReplaceNoteAndLengthCommand(listViewNotes, Line.length, 4, note);
                     commandManager.ExecuteCommand(replaceNoteCommand);
                 }
                 isModified = true;

NeoBleeper/MainWindow.resx

@@ -1201,7 +1201,7 @@
         AAEAAAD/////AQAAAAAAAAAMAgAAAEZTeXN0ZW0uV2luZG93cy5Gb3JtcywgQ3VsdHVyZT1uZXV0cmFs
         LCBQdWJsaWNLZXlUb2tlbj1iNzdhNWM1NjE5MzRlMDg5BQEAAAAmU3lzdGVtLldpbmRvd3MuRm9ybXMu
         SW1hZ2VMaXN0U3RyZWFtZXIBAAAABERhdGEHAgIAAAAJAwAAAA8DAAAAGDQAAAJNU0Z0AUkBTAIBARIB
-        AAEEAS0BBAEtARABAAEQAQAE/wEhAQAI/wFCAU0BNgcAATYDAAEoAwABQAMAAVADAAEBAQABIAYAAVD/
+        AAEMAS0BDAEtARABAAEQAQAE/wEhAQAI/wFCAU0BNgcAATYDAAEoAwABQAMAAVADAAEBAQABIAYAAVD/
         ACcAAxQBGwHfAZQBFQH/Ad4BkQETAf8B3QGOAREB/wHcAYsBDwH/AmUBXgHiMAADXAHDsAAB4wGdARwB
         /wHiAZoBGQH/AeABlwEXAf8B3wGUARUB/wHeAZEBEwH/Ad0BjgERAf8B3AGLAQ8B/wHaAYgBDAH/A04B
         lCQAAysBQQGeAZcBjwH/DAACWgFXAcICYAFdAc6YAAHlAaQBIAH/AeQBoAEeAf8B4wGdARwB/wHiAZoB
@@ -6192,7 +6192,7 @@
         AAEAAAD/////AQAAAAAAAAAMAgAAAEZTeXN0ZW0uV2luZG93cy5Gb3JtcywgQ3VsdHVyZT1uZXV0cmFs
         LCBQdWJsaWNLZXlUb2tlbj1iNzdhNWM1NjE5MzRlMDg5BQEAAAAmU3lzdGVtLldpbmRvd3MuRm9ybXMu
         SW1hZ2VMaXN0U3RyZWFtZXIBAAAABERhdGEHAgIAAAAJAwAAAA8DAAAA3gcAAAJNU0Z0AUkBTAMBAQAB
-        rAEsAawBLAEUAQABFAEABP8BIQEACP8BQgFNATYHAAE2AwABKAMAAVADAAEUAwABAQEAASAGAAEZ/wBv
+        tAEsAbQBLAEUAQABFAEABP8BIQEACP8BQgFNATYHAAE2AwABKAMAAVADAAEUAwABAQEAASAGAAEZ/wBv
         AAQBAz0BaAJXAVYBtQJdAVoBxwJQAU8BmwMkATX/ACEAAw0BEQJdAVsBygHgAZYBFwH/Ad8BlAEVAf8B
         3gGSARQB/wHdAY8BEQH/AdwBjQEQAf8B2wGKAQ4B/wOAAf4DPQFo/wAVAAMtAUUB4wGeARwB/wHiAZsB
         GgH/AeEBmQEZAf8B4AGWARcB/wHfAZQBFQH/Ad4BkgEUAf8B3QGPAREB/wHcAY0BEAH/AdsBigEOAf8B