fix(plugin): quote CLAUDE_PLUGIN_ROOT in hooks for paths with spaces (#442)

All 5 hook command entries in hooks.json referenced \${CLAUDE_PLUGIN_ROOT}
without surrounding double-quotes. On Windows, if the user's profile path
contains a space (e.g. C:\Users\John Doe\...), the shell splits the token
at the space and the script is not found, breaking every hook.

Wrap each expansion in escaped double-quotes so the full path is treated as
a single argument regardless of spaces. Add a Go test (TestHooksJSONPluginRootIsQuoted)
that parses hooks.json and asserts every CLAUDE_PLUGIN_ROOT reference is
properly quoted, and update the existing setup test that asserted the old form.

Closes #420

Author: Alan-TheGentleman

docs/AGENT-SETUP.md

@@ -282,7 +282,7 @@ Add to your `.claude/settings.json` (project) or `~/.claude/settings.json` (glob
 
 With bare MCP, add a [Surviving Compaction](#surviving-compaction-recommended) prompt to your `CLAUDE.md` so the agent remembers to use Engram after context resets.
 
-> **Windows note:** The Claude Code plugin hooks use bash scripts. On Windows, Claude Code runs hooks through Git Bash (bundled with [Git for Windows](https://gitforwindows.org/)) or WSL. The `UserPromptSubmit` hook automatically switches to a fork-light safe path under Git Bash/MSYS2: the first-prompt ToolSearch still runs, while later save-reminder checks are skipped so prompt submission does not block. If Git Bash itself is blocked by Defender/EDR, the plugin also ships `scripts/user-prompt-submit.ps1` as a native PowerShell fallback for local override/testing. **Option C (Bare MCP)** remains the no-hook fallback and works natively on Windows without any shell dependency.
+> **Windows note:** The Claude Code plugin hooks use bash scripts. On Windows, Claude Code runs hooks through Git Bash (bundled with [Git for Windows](https://gitforwindows.org/)) or WSL. The `UserPromptSubmit` hook automatically switches to a fork-light safe path under Git Bash/MSYS2: the first-prompt ToolSearch still runs, while later save-reminder checks are skipped so prompt submission does not block. If Git Bash itself is blocked by Defender/EDR, the plugin also ships `scripts/user-prompt-submit.ps1` as a native PowerShell fallback for local override/testing. **Option C (Bare MCP)** remains the no-hook fallback and works natively on Windows without any shell dependency. Windows usernames containing spaces (e.g. `C:\Users\John Doe\...`) are supported — all hook commands quote `${CLAUDE_PLUGIN_ROOT}` so the path is passed as a single argument even when it contains spaces.
 
 PowerShell fallback test and local override example:
 

internal/setup/setup_test.go

@@ -2277,7 +2277,7 @@ func TestClaudeCodeUserPromptSubmitHookTimeout(t *testing.T) {
 		t.Fatalf("expected one UserPromptSubmit command hook, got %#v", entries)
 	}
 	hook := entries[0].Hooks[0]
-	if hook.Command != "${CLAUDE_PLUGIN_ROOT}/scripts/user-prompt-submit.sh" {
+	if hook.Command != "\"${CLAUDE_PLUGIN_ROOT}/scripts/user-prompt-submit.sh\"" {
 		t.Fatalf("unexpected UserPromptSubmit command %q", hook.Command)
 	}
 	if hook.Timeout != 2 {

plugin/claude-code/hooks/hooks.json

@@ -7,7 +7,7 @@
         "hooks": [
           {
             "type": "command",
-            "command": "${CLAUDE_PLUGIN_ROOT}/scripts/session-start.sh",
+            "command": "\"${CLAUDE_PLUGIN_ROOT}/scripts/session-start.sh\"",
             "timeout": 10,
             "statusMessage": "Loading engram memory..."
           }
@@ -18,7 +18,7 @@
         "hooks": [
           {
             "type": "command",
-            "command": "${CLAUDE_PLUGIN_ROOT}/scripts/post-compaction.sh",
+            "command": "\"${CLAUDE_PLUGIN_ROOT}/scripts/post-compaction.sh\"",
             "timeout": 10,
             "statusMessage": "Recovering engram context after compaction..."
           }
@@ -30,7 +30,7 @@
         "hooks": [
           {
             "type": "command",
-            "command": "${CLAUDE_PLUGIN_ROOT}/scripts/user-prompt-submit.sh",
+            "command": "\"${CLAUDE_PLUGIN_ROOT}/scripts/user-prompt-submit.sh\"",
             "timeout": 2
           }
         ]
@@ -41,7 +41,7 @@
         "hooks": [
           {
             "type": "command",
-            "command": "${CLAUDE_PLUGIN_ROOT}/scripts/subagent-stop.sh",
+            "command": "\"${CLAUDE_PLUGIN_ROOT}/scripts/subagent-stop.sh\"",
             "timeout": 10,
             "async": true
           }
@@ -53,7 +53,7 @@
         "hooks": [
           {
             "type": "command",
-            "command": "${CLAUDE_PLUGIN_ROOT}/scripts/session-stop.sh",
+            "command": "\"${CLAUDE_PLUGIN_ROOT}/scripts/session-stop.sh\"",
             "timeout": 5,
             "async": true
           }

plugin/hooks_quoting_test.go

@@ -0,0 +1,88 @@
+package plugin_test
+
+import (
+	"encoding/json"
+	"os"
+	"strings"
+	"testing"
+)
+
+// hooksJSON is the parsed structure of plugin/claude-code/hooks/hooks.json.
+type hooksJSON struct {
+	Hooks map[string][]hookGroup `json:"hooks"`
+}
+
+type hookGroup struct {
+	Matcher string     `json:"matcher,omitempty"`
+	Hooks   []hookEntry `json:"hooks"`
+}
+
+type hookEntry struct {
+	Type    string `json:"type"`
+	Command string `json:"command,omitempty"`
+	Path    string `json:"path,omitempty"`
+}
+
+// TestHooksJSONPluginRootIsQuoted loads plugin/claude-code/hooks/hooks.json and
+// asserts that every command/path field referencing ${CLAUDE_PLUGIN_ROOT} wraps
+// the variable expansion in double quotes so that Windows usernames or any path
+// component containing spaces does not split the argument at the space.
+//
+// Correct form (POSIX shell):  "${CLAUDE_PLUGIN_ROOT}/scripts/foo.sh"
+// Broken form:                   ${CLAUDE_PLUGIN_ROOT}/scripts/foo.sh
+//
+// The test fails (red) when the variable is present but unquoted, and passes
+// (green) once every occurrence is properly quoted.
+func TestHooksJSONPluginRootIsQuoted(t *testing.T) {
+	root := repoRoot(t)
+	hooksPath := root + "/plugin/claude-code/hooks/hooks.json"
+
+	data, err := os.ReadFile(hooksPath)
+	if err != nil {
+		t.Fatalf("cannot read hooks.json: %v", err)
+	}
+
+	var manifest hooksJSON
+	if err := json.Unmarshal(data, &manifest); err != nil {
+		t.Fatalf("cannot parse hooks.json: %v", err)
+	}
+
+	const varName = "${CLAUDE_PLUGIN_ROOT}"
+	// The quoted form that must surround the variable when it appears in a
+	// command string passed to a POSIX shell.
+	const quotedForm = `"${CLAUDE_PLUGIN_ROOT}`
+
+	checked := 0
+	for eventName, groups := range manifest.Hooks {
+		for gi, group := range groups {
+			for hi, entry := range group.Hooks {
+				for _, field := range []struct {
+					name  string
+					value string
+				}{
+					{"command", entry.Command},
+					{"path", entry.Path},
+				} {
+					if !strings.Contains(field.value, varName) {
+						continue
+					}
+					checked++
+					if !strings.Contains(field.value, quotedForm) {
+						t.Errorf(
+							"hooks[%q][%d].hooks[%d].%s references %s without surrounding double-quotes:\n  got:  %s\n  want: %s...",
+							eventName, gi, hi, field.name,
+							varName,
+							field.value,
+							quotedForm,
+						)
+					}
+				}
+			}
+		}
+	}
+
+	if checked == 0 {
+		t.Fatal("no hook entries reference ${CLAUDE_PLUGIN_ROOT} — test is broken or hooks.json changed")
+	}
+	t.Logf("checked %d hook command/path field(s) for proper quoting", checked)
+}