fix(pi): pin npmCommand to stable mise node spec to prevent package root drift#432
Merged
Merged
Conversation
…oot drift When mise is detected and no npmCommand is configured in settings.json, engram setup pi now writes ["mise", "exec", "node@X.Y.Z", "--", "npm"] using the currently active Node version. Existing npmCommand values are never overwritten, and no change is made when mise is absent. Closes #385
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
engram setup pinow detectsmiseand writes a stablenpmCommand(["mise", "exec", "node@X.Y.Z", "--", "npm"]) to Pi'ssettings.jsonwhen none is configured, preventing package-root drift / duplicate installs when the Node version changes.npmCommandvalues are never overwritten (user customizations survive re-runs).miseis absent (plain npm / other version managers unaffected).Test plan
TestEnsurePiNpmCommandWritesMiseCommand,TestEnsurePiNpmCommandPreservesExisting,TestEnsurePiNpmCommandNoMise,TestEnsurePiNpmCommandMiseVersionFallback,TestInstallPiWritesNpmCommandWhenMiseDetected,TestInstallPiNoNpmCommandWhenNoMisego test ./... && go vet ./... && go build ./...cleanCloses #385