fix(plugin): sync plugin.json version to 0.1.1 to stop recursive cache dirs#455
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes Claude Code plugin version drift by aligning the bundled plugin.json version with the marketplace manifest, preventing repeated cache re-download behavior described in #217.
Changes:
- Updates Claude Code plugin manifest version from
0.1.0to0.1.1. - Adds a Go test that parses both manifests and verifies the marketplace entry version matches the plugin manifest version.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
plugin/claude-code/.claude-plugin/plugin.json |
Syncs plugin version with marketplace metadata. |
plugin/assets_test.go |
Adds manifest parsing structs and TestPluginVersionsMatch regression coverage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #217 — installing the plugin created infinitely nested empty cache dirs (
~/.claude/plugins/cache/engram/0.1.0/engram/0.1.0/...).Change
Sync
plugin/claude-code/.claude-plugin/plugin.jsonversion0.1.0→0.1.1to matchmarketplace.json. The version drift drove repeated re-downloads into versioned cache directories. AddedTestPluginVersionsMatchto catch future drift.What this PR deliberately does NOT do
An earlier exploration switched
marketplace.jsonsourceto thegit-subdirobject form. That was dropped: git-subdir was already reverted once in this repo (commit54a6c52— "Claude Code doesn't recognize it via /plugins"), and upstream claude-plugins-official#585 reports it breaks installs on Claude Code < v2.1.69. Thesourcestays as the relative path. If sparse-clone is wanted later, it should be a separate, deliberately-scoped change with a minimum-client-version expectation.Test plan
go test ./plugin/ -run TestPluginVersionsMatchpasses; both manifests parse as valid JSON.