Quote variables in entrypoint.sh test conditions#628
Merged
giohappy merged 2 commits intoJun 17, 2026
Conversation
FORCE_REINIT is not set in .env.sample (only referenced in a comment), so
on a normal start '[ ${FORCE_REINIT} = "true" ]' runs as '[ = "true" ]'
and errors with '[: =: unary operator expected'. The || chain falls through
to the lock-file check so init still works, but the error is printed on
every startup and the toggle is fragile. Quote the compared variables (also
INVOKE_LOG_STDOUT and IS_CELERY) so an empty value compares cleanly.
giohappy
approved these changes
Jun 17, 2026
This was referenced Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
entrypoint.shcompares unquoted variables in[ ]tests:FORCE_REINITis not set in.env.sample(only mentioned in a comment), so on a normal django container start it is unset and the test becomes[ = "true" ], which errors:The
||chain falls through to the lock-file check, so initialization still works — but the error is printed on every startup, and theFORCE_REINITtoggle is fragile (an empty value errors instead of comparing as a string). The same unquoted pattern is used forINVOKE_LOG_STDOUT(line 8) andIS_CELERY(line 32).Fix
Quote the compared variables so an empty/unset value compares cleanly:
Verification
bash -n entrypoint.shpasses.FORCE_REINITunset: the unquoted form prints[: =: unary operator expected; the quoted form evaluates to false with no error.