[Fixes #14366] Upload error message (#14370)

* [Fixes #14366] Upload error message

* Update geonode/upload/handlers/shapefile/handler.py

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Update geonode/upload/handlers/shapefile/tests.py

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Author: mattiagiupponi

geonode/upload/handlers/shapefile/handler.py

@@ -156,7 +156,7 @@ def is_valid(files, user, **kwargs):
         )
         if not is_valid:
             raise InvalidShapeFileException(
-                detail=f"Some file is missing files with the same name and with the following extension are required: {_shp_ext_needed}"
+                detail=f"Some files are missing. The files need to have the same name with all extensions: {', '.join(ShapeFileHandler._get_ext_needed())}"
             )
 
         return True

geonode/upload/handlers/shapefile/tests.py

@@ -25,6 +25,7 @@
 from django.contrib.auth import get_user_model
 from django.test import TestCase
 from geonode.upload.api.exceptions import UploadParallelismLimitException
+from geonode.upload.handlers.shapefile.exceptions import InvalidShapeFileException
 from geonode.upload.models import UploadParallelismLimit
 from mock import MagicMock, patch, mock_open
 from geonode.upload import project_dir
@@ -108,6 +109,17 @@ def test_promote_to_multi(self):
     def test_is_valid_should_pass_with_valid_shp(self):
         self.handler.is_valid(files=self.valid_shp, user=self.user)
 
+    def test_is_valid_should_not_pass_if_file_is_missing(self):
+        files = self.valid_shp.copy()
+        files.pop("dbf_file")
+        with self.assertRaises(InvalidShapeFileException) as _exp:
+            self.handler.is_valid(files=files, user=self.user)
+        self.assertIn(
+            "Some files are missing. The files need to have the same name with all extensions: shp, prj, dbf, shx",
+            str(_exp.exception),
+            "error message is not the expected one",
+        )
+
     def test_get_ogr2ogr_driver_should_return_the_expected_driver(self):
         expected = ogr.GetDriverByName("ESRI Shapefile")
         actual = self.handler.get_ogr2ogr_driver()