Skip to content

Upgrade to django5#13210

Closed
mattiagiupponi wants to merge 31 commits into
masterfrom
ISSUE_13122
Closed

Upgrade to django5#13210
mattiagiupponi wants to merge 31 commits into
masterfrom
ISSUE_13122

Conversation

@mattiagiupponi

@mattiagiupponi mattiagiupponi commented May 26, 2025

Copy link
Copy Markdown
Contributor

Changes:

  • Update requirements to point to github repo instead of releases version

  • Remove filter horizontal in DatasetAdmin and ProcessingWorkflowAdmin

  • Had to change the default session serializer from PickleSerializer to JSONSerializer -> notes

ImportError: Module "django.contrib.sessions.serializers" does not define a "PickleSerializer" attribute/class 
  • Two warning are raising, still need to check why
/home/mattia/.virtualenvs/dj5/lib/python3.10/site-packages/django/db/backends/utils.py:98: RuntimeWarning: Accessing the database during app initialization is discouraged. To fix this warning, avoid executing queries in AppConfig.ready() or when your app modules are imported.
  warnings.warn(self.APPS_NOT_READY_WARNING_MSG, category=RuntimeWarning)
/home/mattia/.virtualenvs/dj5/lib/python3.10/site-packages/django/db/backends/utils.py:98: RuntimeWarning: Accessing the database during app initialization is discouraged. To fix this warning, avoid executing queries in AppConfig.ready() or when your app modules are imported.
  warnings.warn(self.APPS_NOT_READY_WARNING_MSG, category=RuntimeWarning)
  • remove the password hasher #"django.contrib.auth.hashers.SHA1PasswordHasher", (no longer available) this means that all the user passwords must be updated (the hasher was not raccomanded in django...)

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot Bot added the cla-signed CLA Bot: community license agreement signed label May 26, 2025
@mattiagiupponi mattiagiupponi changed the title Issue 13122 Upgrade to django5 May 26, 2025
@gitguardian

gitguardian Bot commented May 27, 2025

Copy link
Copy Markdown

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
863333 Triggered Generic Password ea629c8 .devcontainer/.env View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@mattiagiupponi mattiagiupponi linked an issue Jun 23, 2025 that may be closed by this pull request
@codecov

codecov Bot commented Jul 17, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 77.77778% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.27%. Comparing base (175dc34) to head (80fb10e).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #13210      +/-   ##
==========================================
+ Coverage   73.25%   73.27%   +0.01%     
==========================================
  Files         915      917       +2     
  Lines       52364    52430      +66     
  Branches     5962     5962              
==========================================
+ Hits        38361    38419      +58     
- Misses      12451    12459       +8     
  Partials     1552     1552              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread geonode/people/hashers.py Dismissed
@sijandh35 sijandh35 marked this pull request as ready for review July 18, 2025 06:34
@mattiagiupponi mattiagiupponi requested a review from sijandh35 July 18, 2025 12:49
@giohappy

Copy link
Copy Markdown
Contributor

closing in favour of #13397

@giohappy giohappy closed this Jul 31, 2025
@giohappy giohappy deleted the ISSUE_13122 branch August 19, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade to Django to 5.2

4 participants