Skip to content

Fix to exception handling for XLSX#14138

Merged
giohappy merged 5 commits into
masterfrom
exception-fix-3581
Jun 18, 2026
Merged

Fix to exception handling for XLSX#14138
giohappy merged 5 commits into
masterfrom
exception-fix-3581

Conversation

@giohappy

@giohappy giohappy commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@cla-bot cla-bot Bot added the cla-signed CLA Bot: community license agreement signed label Apr 14, 2026
@giohappy giohappy changed the title Potential fix for code scanning alert no. 3581: Information exposure through an exception Fix to exception handling for XLSX Apr 14, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the XLSX pre-processing handler to use a static error message when an exception occurs, which prevents the exposure of internal error details. However, the current implementation masks specific validation errors. It is recommended to catch and re-raise InvalidInputFileException separately to preserve detailed feedback for known validation failures while maintaining the generic message for unexpected errors.

Comment thread geonode/upload/handlers/xlsx/handler.py Outdated
Improved error logging for XLSX pre-processing failure.
@giohappy giohappy marked this pull request as ready for review April 14, 2026 09:23
@giohappy giohappy requested a review from mattiagiupponi April 14, 2026 09:24
@codecov

codecov Bot commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.83%. Comparing base (be64508) to head (11a3db8).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #14138       +/-   ##
===========================================
+ Coverage   34.71%   74.83%   +40.11%     
===========================================
  Files         982      984        +2     
  Lines       60496    60692      +196     
  Branches     8247     8290       +43     
===========================================
+ Hits        21002    45416    +24414     
+ Misses      38332    13428    -24904     
- Partials     1162     1848      +686     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@giohappy giohappy merged commit 0e09ec4 into master Jun 18, 2026
18 checks passed
@giohappy giohappy deleted the exception-fix-3581 branch June 18, 2026 07:53
mattiagiupponi pushed a commit that referenced this pull request Jun 18, 2026
(cherry picked from commit 0e09ec4)

Co-authored-by: Giovanni Allegri <giohappy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 5.1.x cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants