Fix to exception handling for XLSX#14138
Merged
Merged
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the XLSX pre-processing handler to use a static error message when an exception occurs, which prevents the exposure of internal error details. However, the current implementation masks specific validation errors. It is recommended to catch and re-raise InvalidInputFileException separately to preserve detailed feedback for known validation failures while maintaining the generic message for unexpected errors.
Improved error logging for XLSX pre-processing failure.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #14138 +/- ##
===========================================
+ Coverage 34.71% 74.83% +40.11%
===========================================
Files 982 984 +2
Lines 60496 60692 +196
Branches 8247 8290 +43
===========================================
+ Hits 21002 45416 +24414
+ Misses 38332 13428 -24904
- Partials 1162 1848 +686 🚀 New features to boost your workflow:
|
mattiagiupponi
approved these changes
Jun 18, 2026
mattiagiupponi
pushed a commit
that referenced
this pull request
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.