Skip to content

[Fixes #11920] Remove call to command rebuild_index in tasks.py#14304

Merged
etj merged 1 commit into
masterfrom
11920_reindex
Jun 8, 2026
Merged

[Fixes #11920] Remove call to command rebuild_index in tasks.py#14304
etj merged 1 commit into
masterfrom
11920_reindex

Conversation

@etj

@etj etj commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

#11920
Remove call to rebuild_index,
Supersedes #11921

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@etj etj self-assigned this Jun 8, 2026
Copilot AI review requested due to automatic review settings June 8, 2026 10:53
@cla-bot cla-bot Bot added the cla-signed CLA Bot: community license agreement signed label Jun 8, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the execution of the 'rebuild_index' Django management command from the 'migrations' task in tasks.py. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes an obsolete manage.py rebuild_index invocation from the migrations() Invoke task, aligning tasks.py with the post–Django 4.2 removal of Haystack and preventing the confusing “Type manage.py help for usage.” message reported in #11920.

Changes:

  • Deleted the rebuild_index ctx.run(...) call from the migrations() task.
  • Removed the surrounding broad try/except: pass block tied to that call.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@etj etj merged commit 77f4f51 into master Jun 8, 2026
9 checks passed
@etj etj deleted the 11920_reindex branch June 8, 2026 10:57
etj added a commit that referenced this pull request Jun 10, 2026
…) (#14317)

(cherry picked from commit 77f4f51)

Co-authored-by: Emanuele Tajariol <etj@geo-solutions.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 5.1.x cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants