Add a Microsoft 365 Graph Email Backend#14314
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @Luke-Sanborn on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added. |
There was a problem hiding this comment.
Code Review
This pull request introduces a new Django email backend, MicrosoftGraphEmailBackend, to send emails via the Microsoft Graph sendMail API, along with configuration options, documentation, and unit tests. The review feedback highlights several critical improvements: parsing the bare email address from mail_from to prevent invalid API URLs when a display name is present, enhancing the _send method to support HTML alternatives, attachments, and custom headers, fixing the saveToSentItems parameter to be a boolean, and utilizing requests.Session to reuse connections and reduce latency when sending multiple emails.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
…, and from email parsing.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @Luke-Sanborn on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added. |
…backend # Conflicts: # .env_local
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @Luke-Sanborn on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added. |
|
hi @Luke-Sanborn did you consider my comment #12907 (comment) ? |
This pull request adds an email backend using the Microsoft Authentication Library (MSAL). Microsoft 365 is phasing out Basic SMTP authentication. This will allow GeoNode users that uses Microsoft 365 to continue using email notifications within GeoNode.
This PR is mostly a rework of an existing pull request #12907
Checklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.