Skip to content

Add a Microsoft 365 Graph Email Backend#14314

Open
Luke-Sanborn wants to merge 3 commits into
GeoNode:masterfrom
VisionaryBroadband:add-ms-graph-email-backend
Open

Add a Microsoft 365 Graph Email Backend#14314
Luke-Sanborn wants to merge 3 commits into
GeoNode:masterfrom
VisionaryBroadband:add-ms-graph-email-backend

Conversation

@Luke-Sanborn

Copy link
Copy Markdown

This pull request adds an email backend using the Microsoft Authentication Library (MSAL). Microsoft 365 is phasing out Basic SMTP authentication. This will allow GeoNode users that uses Microsoft 365 to continue using email notifications within GeoNode.

This PR is mostly a rework of an existing pull request #12907

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot

cla-bot Bot commented Jun 9, 2026

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @Luke-Sanborn on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new Django email backend, MicrosoftGraphEmailBackend, to send emails via the Microsoft Graph sendMail API, along with configuration options, documentation, and unit tests. The review feedback highlights several critical improvements: parsing the bare email address from mail_from to prevent invalid API URLs when a display name is present, enhancing the _send method to support HTML alternatives, attachments, and custom headers, fixing the saveToSentItems parameter to be a boolean, and utilizing requests.Session to reuse connections and reduce latency when sending multiple emails.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread geonode/email_backends/ms_graph_backend.py
Comment thread geonode/email_backends/ms_graph_backend.py Outdated
Comment thread geonode/email_backends/ms_graph_backend.py
@cla-bot

cla-bot Bot commented Jun 22, 2026

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @Luke-Sanborn on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

@cla-bot

cla-bot Bot commented Jun 22, 2026

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @Luke-Sanborn on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

@giohappy

Copy link
Copy Markdown
Contributor

hi @Luke-Sanborn did you consider my comment #12907 (comment) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants