Skip to content

[Fixes #14318] Improve logging#14319

Merged
etj merged 1 commit into
masterfrom
14318_log
Jun 10, 2026
Merged

[Fixes #14318] Improve logging#14319
etj merged 1 commit into
masterfrom
14318_log

Conversation

@etj

@etj etj commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

#14318

  • improve log format
  • add the missing recommended root logger
  • remove the unused mail_admins handler
  • remove the unused logstash and masptore2 loggers
  • replace the deprecated alias WARN to WARNING

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@etj etj self-assigned this Jun 10, 2026
Copilot AI review requested due to automatic review settings June 10, 2026 09:59
@cla-bot cla-bot Bot added the cla-signed CLA Bot: community license agreement signed label Jun 10, 2026
@etj etj requested review from giohappy and mattiagiupponi June 10, 2026 10:00
gemini-code-assist[bot]

This comment was marked as resolved.

This comment was marked as outdated.

@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.90%. Comparing base (0495358) to head (1d781e1).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14319      +/-   ##
==========================================
- Coverage   74.91%   74.90%   -0.01%     
==========================================
  Files         982      982              
  Lines       60496    60496              
  Branches     8247     8247              
==========================================
- Hits        45319    45317       -2     
- Misses      13346    13349       +3     
+ Partials     1831     1830       -1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@etj etj force-pushed the 14318_log branch 3 times, most recently from 42830af to 1d781e1 Compare June 10, 2026 10:33
@etj etj requested a review from Copilot June 10, 2026 10:34
@etj etj linked an issue Jun 10, 2026 that may be closed by this pull request

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

geonode/settings.py:682

  • The importer logger is set to INFO but has no handler of its own; with the root logger set to WARNING, any INFO records from importer will be dropped when they propagate to root. Either raise the root level or attach the console handler directly to importer (and disable propagation) so the configured INFO level has effect.
        "importer": {
            "level": "INFO",
        },

@etj etj merged commit 2c0fdfd into master Jun 10, 2026
7 checks passed
@etj etj deleted the 14318_log branch June 10, 2026 14:20
etj added a commit that referenced this pull request Jun 10, 2026
(cherry picked from commit 2c0fdfd)

Co-authored-by: Emanuele Tajariol <etj@geo-solutions.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 5.1.x cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve logging

4 participants