Skip to content

[Fixes #14344] Pack rdf files in build distribution#14345

Merged
mattiagiupponi merged 1 commit into
masterfrom
14344_pack_rdf
Jun 17, 2026
Merged

[Fixes #14344] Pack rdf files in build distribution#14345
mattiagiupponi merged 1 commit into
masterfrom
14344_pack_rdf

Conversation

@etj

@etj etj commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Fixes #14344

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@etj etj self-assigned this Jun 17, 2026
Copilot AI review requested due to automatic review settings June 17, 2026 10:37
@cla-bot cla-bot Bot added the cla-signed CLA Bot: community license agreement signed label Jun 17, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request attempts to include RDF thesauri files by adding a [tool.setuptools.package-data] configuration to pyproject.toml. However, this configuration will be ignored because setup.py overrides it. It is recommended to remove this block and instead update MANIFEST.in to include the .rdf files.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread pyproject.toml

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates GeoNode’s setuptools packaging configuration so RDF thesaurus files stored under **/thesauri/*.rdf are included in built distributions, enabling the thesaurus autoload feature to work when GeoNode is installed from a packaged artifact.

Changes:

  • Adds a tool.setuptools.package-data entry to include **/thesauri/*.rdf under the geonode package.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov

codecov Bot commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.95%. Comparing base (be64508) to head (cbc98fe).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #14345       +/-   ##
===========================================
+ Coverage   34.71%   74.95%   +40.23%     
===========================================
  Files         982      983        +1     
  Lines       60496    60615      +119     
  Branches     8247     8266       +19     
===========================================
+ Hits        21002    45434    +24432     
+ Misses      38332    13351    -24981     
- Partials     1162     1830      +668     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mattiagiupponi mattiagiupponi merged commit 109bc4b into master Jun 17, 2026
21 checks passed
@mattiagiupponi mattiagiupponi deleted the 14344_pack_rdf branch June 17, 2026 15:58
mattiagiupponi pushed a commit that referenced this pull request Jun 17, 2026
(cherry picked from commit 109bc4b)

Co-authored-by: Emanuele Tajariol <etj@geo-solutions.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 5.1.x cla-signed CLA Bot: community license agreement signed configuration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pack rdf files in build distribution

3 participants