[Fixes #14366] Upload error message#14370
Conversation
There was a problem hiding this comment.
Code Review
This pull request improves the error message raised when shapefile validation fails due to missing files, dynamically listing the required extensions, and adds a corresponding unit test. The review feedback identifies a grammatical error ('needs to have' instead of 'need to have') and a duplicate word typo ('with with') in the new error message, along with the need to update the corresponding test assertion.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
* [Fixes #14366] Upload error message * Update geonode/upload/handlers/shapefile/handler.py --------- (cherry picked from commit fe0f319) Co-authored-by: mattiagiupponi <51856725+mattiagiupponi@users.noreply.github.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Checklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.