Skip to content

[Fixes #14366] Upload error message#14370

Merged
mattiagiupponi merged 3 commits into
masterfrom
ISSUE_14366
Jun 22, 2026
Merged

[Fixes #14366] Upload error message#14370
mattiagiupponi merged 3 commits into
masterfrom
ISSUE_14366

Conversation

@mattiagiupponi

Copy link
Copy Markdown
Contributor

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@mattiagiupponi mattiagiupponi requested a review from etj June 22, 2026 11:17
@cla-bot cla-bot Bot added the cla-signed CLA Bot: community license agreement signed label Jun 22, 2026
@mattiagiupponi mattiagiupponi linked an issue Jun 22, 2026 that may be closed by this pull request

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves the error message raised when shapefile validation fails due to missing files, dynamically listing the required extensions, and adds a corresponding unit test. The review feedback identifies a grammatical error ('needs to have' instead of 'need to have') and a duplicate word typo ('with with') in the new error message, along with the need to update the corresponding test assertion.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread geonode/upload/handlers/shapefile/handler.py Outdated
Comment thread geonode/upload/handlers/shapefile/tests.py Outdated
mattiagiupponi and others added 2 commits June 22, 2026 13:18
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@mattiagiupponi mattiagiupponi merged commit fe0f319 into master Jun 22, 2026
15 checks passed
@mattiagiupponi mattiagiupponi deleted the ISSUE_14366 branch June 22, 2026 12:50
mattiagiupponi added a commit that referenced this pull request Jun 22, 2026
* [Fixes #14366] Upload error message

* Update geonode/upload/handlers/shapefile/handler.py


---------


(cherry picked from commit fe0f319)

Co-authored-by: mattiagiupponi <51856725+mattiagiupponi@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 5.1.x cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upload error message

2 participants