Skip to content

[Fixes #14358] Align GWC template to the default GWC configuration#14378

Merged
giohappy merged 1 commit into
masterfrom
14358_gwc_template
Jun 23, 2026
Merged

[Fixes #14358] Align GWC template to the default GWC configuration#14378
giohappy merged 1 commit into
masterfrom
14358_gwc_template

Conversation

@etj

@etj etj commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Aligned to the default GWC config and the official XML layer representation

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@etj etj added this to the 5.1.0 milestone Jun 23, 2026
@etj etj requested a review from giohappy June 23, 2026 07:39
@etj etj self-assigned this Jun 23, 2026
Copilot AI review requested due to automatic review settings June 23, 2026 07:39
@cla-bot cla-bot Bot added the cla-signed CLA Bot: community license agreement signed label Jun 23, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the GeoServer Layer XML template create_template.xml by changing the height in metaWidthHeight from 1 to 2, adding a new gridSubset for EPSG:900913x2, and removing the expireCache, expireClients, and cacheWarningSkips elements. There are no review comments to evaluate, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates GeoWebCache (GWC) layer XML template used by GeoNode’s GeoServer management command(s) to better match GeoServer/GWC’s default layer configuration and official REST XML representation.

Changes:

  • Adjusts metatile dimensions (metaWidthHeight) from 2x1 to 2x2.
  • Adds the EPSG:900913x2 grid subset to the generated layer definition.
  • Removes expireCache, expireClients, and cacheWarningSkips elements from the template.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread geonode/geoserver/management/commands/gwc_subcommands/create_template.xml Outdated
@etj etj force-pushed the 14358_gwc_template branch from c752f6c to 60254a4 Compare June 23, 2026 07:42
@giohappy giohappy merged commit b29cb7e into master Jun 23, 2026
8 checks passed
@giohappy giohappy deleted the 14358_gwc_template branch June 23, 2026 07:52
@github-actions

Copy link
Copy Markdown
Contributor

The backport to 5.1.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-5.1.x 5.1.x
# Navigate to the new working tree
cd .worktrees/backport-5.1.x
# Create a new branch
git switch --create backport-14378-to-5.1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b29cb7e8f4c59f34925e55d960ffcc4f15fef6f6
# Push it to GitHub
git push --set-upstream origin backport-14378-to-5.1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-5.1.x

Then, create a pull request where the base branch is 5.1.x and the compare/head branch is backport-14378-to-5.1.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 5.1.x cla-signed CLA Bot: community license agreement signed configuration enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants