[1431] Upgrade codebase to Java 17 language features

[groldan]

Fixes #1431

[pmauduit]

Tested after rebasing onto main, and got no error so far issuing a mvn clean verify:

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for geowebcache 1.28-SNAPSHOT:
[INFO] 
[INFO] geowebcache ........................................ SUCCESS [  6.817 s]
[INFO] gwc-core ........................................... SUCCESS [04:27 min]
[INFO] gwc-georss ......................................... SUCCESS [ 18.129 s]
[INFO] gwc-gmaps .......................................... SUCCESS [  6.727 s]
[INFO] gwc-kml ............................................ SUCCESS [  5.880 s]
[INFO] gwc-rest ........................................... SUCCESS [ 56.930 s]
[INFO] gwc-tms ............................................ SUCCESS [ 10.119 s]
[INFO] gwc-ve ............................................. SUCCESS [  6.085 s]
[INFO] gwc-wms ............................................ SUCCESS [01:57 min]
[INFO] gwc-wmts ........................................... SUCCESS [ 21.895 s]
[INFO] Disk Quota management module ....................... SUCCESS [  3.722 s]
[INFO] Disk Quota management module - core service ........ SUCCESS [ 13.673 s]
[INFO] Disk Quota management module - BerkeleyDB backend .. SUCCESS [  9.315 s]
[INFO] Disk Quota management module - JDBC backends ....... SUCCESS [ 27.763 s]
[INFO] ArcGIS Server tile cache support ................... SUCCESS [ 37.962 s]
[INFO] MBTiles cache support .............................. SUCCESS [04:10 min]
[INFO] gwc-distributed .................................... SUCCESS [ 16.269 s]
[INFO] AWS S3 Storage ..................................... SUCCESS [ 29.782 s]
[INFO] SQLite Storage ..................................... SUCCESS [01:53 min]
[INFO] Swift Storage ...................................... SUCCESS [ 23.145 s]
[INFO] Web module ......................................... SUCCESS [ 39.197 s]
[INFO] gwc-azure-blob ..................................... SUCCESS [ 11.736 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  18:17 min
[INFO] Finished at: 2025-08-27T15:23:13+02:00
[INFO] ------------------------------------------------------------------------

I can see this message when building though:

OpenJDK 64-Bit Server VM warning: Ignoring option --illegal-access=warn; support was removed in 17.0

And wondering if we could get rid of the option from the pom file:

• https://github.com/GeoWebCache/geowebcache/blob/main/geowebcache/pom.xml#L347 and
• https://github.com/GeoWebCache/geowebcache/blob/main/geowebcache/pom.xml#L563

[aaime]

I'd say yes, we are building the main branch with java 17 +, so it's ignored anyways no?

[pmauduit]

Just one potentially useless "string".formatted() caught my eyes, apart from that LGTM.
I'd have expected more code rewrite patterns in the diff, but discovered some things I was not aware of already.

[pmauduit]

so it's ignored anyways no?

yes, it did not harm my compilation at least

[aaime]

Does not compile, updating to the latest main will fix it, in particular this commit:

commit 665371576b8e134a9355f4ca49952839f897834c (HEAD -> main, gwc/main)
Author: Jody Garnett <jody.garnett@gmail.com>
Date:   Sun Sep 14 20:38:12 2025 -0700

    Use GeoTools ImageWorker to avoid having to care about specific ImageN Operator

[groldan]

@aaime thanks, all working after rebasing

[aaime]

Had a look at the PR, everything looks fine to me, good to merge IMHO.