Skip to content

Commit 4db343f

Browse files
Use Any type for district_number to accept whatever the API returns
1 parent 0cfe585 commit 4db343f

2 files changed

Lines changed: 9 additions & 9 deletions

File tree

src/geocodio/models.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,8 @@ class Timezone(ApiModelMixin):
8282
@dataclass(slots=True, frozen=True)
8383
class CongressionalDistrict(ApiModelMixin):
8484
name: str
85-
district_number: int
86-
congress_number: str
85+
district_number: Any = None
86+
congress_number: Optional[str] = None
8787
ocd_id: Optional[str] = None
8888
extras: Dict[str, Any] = field(default_factory=dict, repr=False)
8989

@@ -95,8 +95,8 @@ class StateLegislativeDistrict(ApiModelMixin):
9595
"""
9696

9797
name: str
98-
district_number: int
99-
chamber: str # 'house' or 'senate'
98+
district_number: Any = None
99+
chamber: Optional[str] = None # 'house' or 'senate'
100100
ocd_id: Optional[str] = None
101101
proportion: Optional[float] = None # Proportion of overlap with the address
102102
extras: Dict[str, Any] = field(default_factory=dict, repr=False)

tests/e2e/test_api.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ def test_integration_with_fields(client):
111111
if fields.congressional_districts:
112112
cd = fields.congressional_districts[0]
113113
assert cd.name is not None
114-
assert isinstance(cd.district_number, int)
114+
assert cd.district_number is not None
115115
assert cd.congress_number is not None
116116

117117
if fields.census2020:
@@ -205,7 +205,7 @@ def test_integration_with_state_legislative_districts(client):
205205
if fields.state_legislative_districts:
206206
district = fields.state_legislative_districts[0]
207207
assert district.name is not None
208-
assert isinstance(district.district_number, int)
208+
assert district.district_number is not None
209209
assert district.chamber in ["house", "senate"]
210210
if district.ocd_id:
211211
assert isinstance(district.ocd_id, str)
@@ -216,7 +216,7 @@ def test_integration_with_state_legislative_districts(client):
216216
if fields.state_legislative_districts_next:
217217
district = fields.state_legislative_districts_next[0]
218218
assert district.name is not None
219-
assert isinstance(district.district_number, int)
219+
assert district.district_number is not None
220220
assert district.chamber in ["house", "senate"]
221221
if district.ocd_id:
222222
assert isinstance(district.ocd_id, str)
@@ -249,7 +249,7 @@ def test_integration_with_school_districts(client):
249249
district = fields.school_districts[0]
250250
assert district.name is not None
251251
if district.district_number:
252-
assert isinstance(district.district_number, str)
252+
assert district.district_number is not None
253253
if district.lea_id:
254254
assert isinstance(district.lea_id, str)
255255
if district.nces_id:
@@ -676,7 +676,7 @@ def test_integration_with_congressional_district_variants(client):
676676
if fields.congressional_districts:
677677
for district in fields.congressional_districts:
678678
assert district.name is not None
679-
assert isinstance(district.district_number, int)
679+
assert district.district_number is not None
680680
assert district.congress_number is not None
681681
if district.ocd_id:
682682
assert isinstance(district.ocd_id, str)

0 commit comments

Comments
 (0)