Merge pull request #159 from Geode-solutions/fix/clear_attributes_before_instantiation

MelchiorSchuh · web-flow · commit 0f271b8b016c · 2025-07-22T10:29:40.000+02:00
fix(ImplicitModel): Fixed potential bug if attributes were already in…
diff --git a/src/geode/geosciences/implicit/representation/core/implicit_cross_section.cpp b/src/geode/geosciences/implicit/representation/core/implicit_cross_section.cpp
@@ -213,6 +213,7 @@ namespace geode
         void instantiate_implicit_attribute_on_surfaces(
             const ImplicitCrossSection& model )
         {
+            implicit_attributes_.clear();
             implicit_attributes_.reserve( model.nb_surfaces() );
             for( const auto& surface : model.surfaces() )
             {
diff --git a/src/geode/geosciences/implicit/representation/core/implicit_structural_model.cpp b/src/geode/geosciences/implicit/representation/core/implicit_structural_model.cpp
@@ -211,6 +211,7 @@ namespace geode
         void instantiate_implicit_attribute_on_blocks(
             const ImplicitStructuralModel& model )
         {
+            implicit_attributes_.clear();
             implicit_attributes_.reserve( model.nb_blocks() );
             for( const auto& block : model.blocks() )
             {

Original file line number	Diff line number	Diff line change
`@@ -213,6 +213,7 @@ namespace geode`
`213`	`213`	`void instantiate_implicit_attribute_on_surfaces(`
`214`	`214`	`const ImplicitCrossSection& model )`
`215`	`215`	`{`
	`216`	`+ implicit_attributes_.clear();`
`216`	`217`	`implicit_attributes_.reserve( model.nb_surfaces() );`
`217`	`218`	`for( const auto& surface : model.surfaces() )`
`218`	`219`	`{`
Original file line number	Diff line number	Diff line change
`@@ -211,6 +211,7 @@ namespace geode`
`211`	`211`	`void instantiate_implicit_attribute_on_blocks(`
`212`	`212`	`const ImplicitStructuralModel& model )`
`213`	`213`	`{`
	`214`	`+ implicit_attributes_.clear();`
`214`	`215`	`implicit_attributes_.reserve( model.nb_blocks() );`
`215`	`216`	`for( const auto& block : model.blocks() )`
`216`	`217`	`{`