fix(Python): add smart holder on Identified objects

panquez · panquez · commit 343cdd8a6064 · 2026-03-11T15:44:22.000+01:00
diff --git a/bindings/python/src/explicit/mixin/core/fault.hpp b/bindings/python/src/explicit/mixin/core/fault.hpp
@@ -25,7 +25,8 @@
 
 #define PYTHON_FAULT( dimension )                                              \
     const auto name##dimension = "Fault" + std::to_string( dimension ) + "D";  \
-    pybind11::class_< Fault##dimension##D, Component##dimension##D >           \
+    pybind11::class_< Fault##dimension##D, Component##dimension##D,            \
+        pybind11::smart_holder >                                               \
         fault##dimension##D( module, name##dimension.c_str() );                \
                                                                                \
     pybind11::enum_< Fault##dimension##D::FAULT_TYPE >(                        \
diff --git a/bindings/python/src/explicit/mixin/core/fault_block.hpp b/bindings/python/src/explicit/mixin/core/fault_block.hpp
@@ -26,8 +26,8 @@
 #define PYTHON_FAULT_BLOCK( dimension )                                        \
     const auto name##dimension =                                               \
         "FaultBlock" + std::to_string( dimension ) + "D";                      \
-    pybind11::class_< FaultBlock##dimension##D, Component##dimension##D >(     \
-        module, name##dimension.c_str() )                                      \
+    pybind11::class_< FaultBlock##dimension##D, Component##dimension##D,       \
+        pybind11::smart_holder >( module, name##dimension.c_str() )            \
         .def( "component_id", &FaultBlock##dimension##D::component_id )
 
 namespace geode
diff --git a/bindings/python/src/explicit/mixin/core/fault_blocks.hpp b/bindings/python/src/explicit/mixin/core/fault_blocks.hpp
@@ -27,7 +27,7 @@
 #define PYTHON_FAULT_BLOCKS( dimension )                                       \
     const auto name##dimension =                                               \
         "FaultBlocks" + std::to_string( dimension ) + "D";                     \
-    pybind11::class_< FaultBlocks##dimension##D >(                             \
+    pybind11::class_< FaultBlocks##dimension##D, pybind11::smart_holder >(     \
         module, name##dimension.c_str() )                                      \
         .def( "nb_fault_blocks", &FaultBlocks##dimension##D::nb_fault_blocks ) \
         .def( "fault_block", &FaultBlocks##dimension##D::fault_block,          \
diff --git a/bindings/python/src/explicit/mixin/core/faults.hpp b/bindings/python/src/explicit/mixin/core/faults.hpp
@@ -26,7 +26,7 @@
 
 #define PYTHON_FAULTS( dimension )                                             \
     const auto name##dimension = "Faults" + std::to_string( dimension ) + "D"; \
-    pybind11::class_< Faults##dimension##D >(                                  \
+    pybind11::class_< Faults##dimension##D, pybind11::smart_holder >(          \
         module, name##dimension.c_str() )                                      \
         .def( "nb_faults", &Faults##dimension##D::nb_faults )                  \
         .def( "fault", &Faults##dimension##D::fault,                           \
diff --git a/bindings/python/src/explicit/mixin/core/horizon.hpp b/bindings/python/src/explicit/mixin/core/horizon.hpp
@@ -26,7 +26,8 @@
 #define PYTHON_HORIZON( dimension )                                            \
     const auto name##dimension =                                               \
         "Horizon" + std::to_string( dimension ) + "D";                         \
-    pybind11::class_< Horizon##dimension##D, Component##dimension##D >         \
+    pybind11::class_< Horizon##dimension##D, Component##dimension##D,          \
+        pybind11::smart_holder >                                               \
         horizon##dimension##D( module, name##dimension.c_str() );              \
                                                                                \
     pybind11::enum_< Horizon##dimension##D::CONTACT_TYPE >(                    \
diff --git a/bindings/python/src/explicit/mixin/core/horizons.hpp b/bindings/python/src/explicit/mixin/core/horizons.hpp
@@ -27,7 +27,7 @@
 #define PYTHON_HORIZONS( dimension )                                           \
     const auto name##dimension =                                               \
         "Horizons" + std::to_string( dimension ) + "D";                        \
-    pybind11::class_< Horizons##dimension##D >(                                \
+    pybind11::class_< Horizons##dimension##D, pybind11::smart_holder >(        \
         module, name##dimension.c_str() )                                      \
         .def( "nb_horizons", &Horizons##dimension##D::nb_horizons )            \
         .def( "horizon", &Horizons##dimension##D::horizon,                     \
diff --git a/bindings/python/src/explicit/mixin/core/stratigraphic_unit.hpp b/bindings/python/src/explicit/mixin/core/stratigraphic_unit.hpp
@@ -27,7 +27,8 @@
     const auto name##dimension =                                               \
         "StratigraphicUnit" + std::to_string( dimension ) + "D";               \
     pybind11::class_< StratigraphicUnit##dimension##D,                         \
-        Component##dimension##D >( module, name##dimension.c_str() )           \
+        Component##dimension##D, pybind11::smart_holder >(                     \
+        module, name##dimension.c_str() )                                      \
         .def( "component_id", &StratigraphicUnit##dimension##D::component_id )
 
 namespace geode
diff --git a/bindings/python/src/explicit/mixin/core/stratigraphic_units.hpp b/bindings/python/src/explicit/mixin/core/stratigraphic_units.hpp
@@ -27,8 +27,8 @@
 #define PYTHON_STRATIGRAPHIC_UNITS( dimension )                                \
     const auto name##dimension =                                               \
         "StratigraphicUnits" + std::to_string( dimension ) + "D";              \
-    pybind11::class_< StratigraphicUnits##dimension##D >(                      \
-        module, name##dimension.c_str() )                                      \
+    pybind11::class_< StratigraphicUnits##dimension##D,                        \
+        pybind11::smart_holder >( module, name##dimension.c_str() )            \
         .def( "nb_stratigraphic_units",                                        \
             &StratigraphicUnits##dimension##D::nb_stratigraphic_units )        \
         .def( "stratigraphic_unit",                                            \
diff --git a/bindings/python/src/explicit/representation/core/cross_section.hpp b/bindings/python/src/explicit/representation/core/cross_section.hpp
@@ -30,7 +30,8 @@ namespace geode
     void define_cross_section( pybind11::module& module )
     {
         pybind11::class_< CrossSection, Section, Faults2D, Horizons2D,
-            FaultBlocks2D, StratigraphicUnits2D >( module, "CrossSection" )
+            FaultBlocks2D, StratigraphicUnits2D, pybind11::smart_holder >(
+            module, "CrossSection" )
             .def( pybind11::init<>() )
             .def( pybind11::init( []( Section& section ) {
                 return CrossSection{ section.clone() };
diff --git a/bindings/python/src/explicit/representation/core/structural_model.hpp b/bindings/python/src/explicit/representation/core/structural_model.hpp
@@ -30,7 +30,8 @@ namespace geode
     void define_structural_model( pybind11::module& module )
     {
         pybind11::class_< StructuralModel, BRep, Faults3D, Horizons3D,
-            FaultBlocks3D, StratigraphicUnits3D >( module, "StructuralModel" )
+            FaultBlocks3D, StratigraphicUnits3D, pybind11::smart_holder >(
+            module, "StructuralModel" )
             .def( pybind11::init<>() )
             .def( pybind11::init( []( BRep& model ) {
                 return StructuralModel{ model.clone() };
diff --git a/bindings/python/src/implicit/mixin/core/stratigraphic_relationships.hpp b/bindings/python/src/implicit/mixin/core/stratigraphic_relationships.hpp
@@ -27,7 +27,7 @@ namespace geode
 {
     void define_stratigraphic_relationships( pybind11::module& module )
     {
-        pybind11::class_< StratigraphicRelationships >(
+        pybind11::class_< StratigraphicRelationships, pybind11::smart_holder >(
             module, "StratigraphicRelationships" )
             .def( pybind11::init<>() )
             .def( "is_above", &StratigraphicRelationships::is_above )
diff --git a/bindings/python/src/implicit/representation/core/horizons_stack.hpp b/bindings/python/src/implicit/representation/core/horizons_stack.hpp
@@ -29,8 +29,8 @@
     const auto name##dimension =                                               \
         "HorizonsStack" + std::to_string( dimension ) + "D";                   \
     pybind11::class_< HorizonsStack##dimension##D, StratigraphicRelationships, \
-        Horizons##dimension##D, StratigraphicUnits##dimension##D,              \
-        Identifier >( module, name##dimension.c_str() )                        \
+        Horizons##dimension##D, StratigraphicUnits##dimension##D, Identifier,  \
+        pybind11::smart_holder >( module, name##dimension.c_str() )            \
         .def( pybind11::init<>() )                                             \
         .def( "native_extension",                                              \
             &HorizonsStack##dimension##D::native_extension )                   \
diff --git a/bindings/python/src/implicit/representation/core/implicit_cross_section.hpp b/bindings/python/src/implicit/representation/core/implicit_cross_section.hpp
@@ -29,8 +29,8 @@ namespace geode
 {
     void define_implicit_cross_section( pybind11::module& module )
     {
-        pybind11::class_< ImplicitCrossSection, CrossSection >(
-            module, "ImplicitCrossSection" )
+        pybind11::class_< ImplicitCrossSection, CrossSection,
+            pybind11::smart_holder >( module, "ImplicitCrossSection" )
             .def( pybind11::init<>() )
             .def( pybind11::init( []( CrossSection& cross_section ) {
                 return ImplicitCrossSection{ cross_section.clone() };
diff --git a/bindings/python/src/implicit/representation/core/implicit_structural_model.hpp b/bindings/python/src/implicit/representation/core/implicit_structural_model.hpp
@@ -31,8 +31,8 @@ namespace geode
 {
     void define_implicit_structural_model( pybind11::module& module )
     {
-        pybind11::class_< ImplicitStructuralModel, StructuralModel >(
-            module, "ImplicitStructuralModel" )
+        pybind11::class_< ImplicitStructuralModel, StructuralModel,
+            pybind11::smart_holder >( module, "ImplicitStructuralModel" )
             .def( pybind11::init<>() )
             .def( pybind11::init( []( StructuralModel& model ) {
                 return ImplicitStructuralModel{ model.clone() };
diff --git a/bindings/python/src/implicit/representation/core/stratigraphic_model.hpp b/bindings/python/src/implicit/representation/core/stratigraphic_model.hpp
@@ -35,8 +35,8 @@ namespace geode
 {
     void define_stratigraphic_model( pybind11::module& module )
     {
-        pybind11::class_< StratigraphicModel, ImplicitStructuralModel >(
-            module, "StratigraphicModel" )
+        pybind11::class_< StratigraphicModel, ImplicitStructuralModel,
+            pybind11::smart_holder >( module, "StratigraphicModel" )
             .def( pybind11::init<>() )
             .def( pybind11::init( []( ImplicitStructuralModel& model ) {
                 return StratigraphicModel{ model.clone() };
diff --git a/bindings/python/src/implicit/representation/core/stratigraphic_section.hpp b/bindings/python/src/implicit/representation/core/stratigraphic_section.hpp
@@ -35,8 +35,8 @@ namespace geode
 {
     void define_stratigraphic_section( pybind11::module& module )
     {
-        pybind11::class_< StratigraphicSection, ImplicitCrossSection >(
-            module, "StratigraphicSection" )
+        pybind11::class_< StratigraphicSection, ImplicitCrossSection,
+            pybind11::smart_holder >( module, "StratigraphicSection" )
             .def( pybind11::init<>() )
             .def( pybind11::init( []( ImplicitCrossSection& cross_section ) {
                 return StratigraphicSection{ cross_section.clone() };

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,8 @@`
`25`	`25`
`26`	`26`	`#define PYTHON_FAULT( dimension ) \`
`27`	`27`	`const auto name##dimension = "Fault" + std::to_string( dimension ) + "D"; \`
`28`		`- pybind11::class_< Fault##dimension##D, Component##dimension##D > \`
	`28`	`+ pybind11::class_< Fault##dimension##D, Component##dimension##D, \`
	`29`	`+ pybind11::smart_holder > \`
`29`	`30`	`fault##dimension##D( module, name##dimension.c_str() ); \`
`30`	`31`	`\`
`31`	`32`	`pybind11::enum_< Fault##dimension##D::FAULT_TYPE >( \`