fix python

Author: BenPinet

bindings/python/src/implicit/representation/core/helpers.hpp

@@ -67,15 +67,14 @@ namespace geode
                 .def( "horizon_id_from_name_2d", &horizon_id_from_name< 2 > )
                 .def( "horizon_id_from_name_3d", &horizon_id_from_name< 3 > )
                 .def( "implicit_section_from_cross_section_scalar_field",
-                    []( CrossSection& model, std::string_view attribute_name ) {
+                    []( CrossSection& model, const uuid& attribute_id ) {
                         return implicit_section_from_cross_section_scalar_field(
-                            model.clone(), attribute_name );
+                            model.clone(), attribute_id );
                     } )
                 .def( "implicit_model_from_structural_model_scalar_field",
-                    []( StructuralModel& model,
-                        std::string_view attribute_name ) {
+                    []( StructuralModel& model, const uuid& attribute_id ) {
                         return implicit_model_from_structural_model_scalar_field(
-                            model.clone(), attribute_name );
+                            model.clone(), attribute_id );
                     } )
                 .def( "stratigraphic_model_from_implicit_model_and_coords",
                     []( ImplicitStructuralModel& implicit_model,

bindings/python/tests/implicit/test-py-stratigraphic-section.py

@@ -43,9 +43,12 @@ def import_section_with_stratigraphy():
 
     for surface in stratigraphic_section.surfaces():
         mesh = surface.mesh()
-        scalar_attribute = mesh.vertex_attribute_manager().find_attribute_double(
+        scalar_attributes = mesh.vertex_attribute_manager().attribute_ids_matching_name(
             "curvature_min"
         )
+        scalar_attribute = mesh.vertex_attribute_manager().find_read_only_attribute_double(
+            scalar_attributes[0]
+        )
         for vertex_id in range(mesh.nb_vertices()):
             model_builder.set_stratigraphic_coordinates(
                 surface,

tests/implicit/test-stratigraphic-model.cpp

@@ -259,14 +259,17 @@ int main()
     {
         geode::Logger::info( "Starting test" );
         geode::OpenGeodeGeosciencesImplicitLibrary::initialize();
+        geode::Logger::set_level( geode::Logger::LEVEL::debug );
         geode::StratigraphicModel model{ geode::load_structural_model(
             absl::StrCat( geode::DATA_PATH, "vri2.og_strm" ) ) };
         const geode::uuid block1_id{ "00000000-c271-42e7-8000-00002c3147ed" };
         add_horizons_stack_to_model( model, block1_id );
         test_model( model, block1_id );
         geode::Logger::info( "Testing copy" );
         test_copy( model, block1_id );
+        DEBUG( "Testing save stratigraphic surfaces" );
         test_save_stratigraphic_surfaces( model );
+        DEBUG( "Testing IO" );
         test_io( model, block1_id );
 
         geode::Logger::info( "TEST SUCCESS" );