Added model validity functions

Author: MelchiorSchuh

bindings/python/src/inspection/topology/brep_topology.hpp

@@ -41,6 +41,10 @@ namespace geode
             .def_readwrite( "unique_vertices_linked_to_multiple_corners",
                 &BRepCornersTopologyInspectionResult::
                     unique_vertices_linked_to_multiple_corners )
+            .def_readwrite(
+                "unique_vertices_linked_to_multiply_embedded_corner",
+                &BRepCornersTopologyInspectionResult::
+                    unique_vertices_linked_to_multiply_embedded_corner )
             .def_readwrite(
                 "unique_vertices_linked_to_not_internal_nor_boundary_corner",
                 &BRepCornersTopologyInspectionResult::

include/geode/inspector/inspection/topology/brep_corners_topology.hpp

@@ -52,6 +52,11 @@ namespace geode
         InspectionIssues< index_t > unique_vertices_linked_to_multiple_corners{
             "unique vertices shared by several Corners"
         };
+        InspectionIssues< index_t >
+            unique_vertices_linked_to_multiply_embedded_corner{
+                "unique vertices linked to a Corner embedded in more than two "
+                "components"
+            };
         InspectionIssues< index_t >
             unique_vertices_linked_to_not_internal_nor_boundary_corner{
                 "unique vertices linked to a Corner with neither "
@@ -95,6 +100,9 @@ namespace geode
             unique_vertex_has_multiple_corners(
                 index_t unique_vertex_index ) const;
 
+        [[nodiscard]] std::optional< std::string > corner_is_multiply_embedded(
+            index_t unique_vertex_index ) const;
+
         [[nodiscard]] std::optional< std::string >
             corner_is_not_internal_nor_boundary(
                 index_t unique_vertex_index ) const;

include/geode/inspector/validity/brep_validity.hpp

@@ -0,0 +1,38 @@
+/*
+ * Copyright (c) 2019 - 2026 Geode-solutions
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ *
+ */
+
+#pragma once
+
+#include <geode/inspector/validity/common.hpp>
+
+namespace geode
+{
+    class BRep;
+    struct ObjectValidity;
+} // namespace geode
+
+namespace geode
+{
+    [[nodiscard]] ObjectValidity opengeode_inspector_validity_api is_brep_valid(
+        const BRep& brep );
+} // namespace geode

include/geode/inspector/validity/section_validity.hpp

@@ -0,0 +1,38 @@
+/*
+ * Copyright (c) 2019 - 2026 Geode-solutions
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ *
+ */
+
+#pragma once
+
+#include <geode/inspector/validity/common.hpp>
+
+namespace geode
+{
+    class Section;
+    struct ObjectValidity;
+} // namespace geode
+
+namespace geode
+{
+    [[nodiscard]] ObjectValidity opengeode_inspector_validity_api
+        is_section_valid( const Section& section );
+} // namespace geode

src/geode/inspector/inspection/topology/brep_corners_topology.cpp

@@ -39,6 +39,7 @@ namespace geode
         return corners_not_meshed.nb_issues()
                + corners_not_linked_to_a_unique_vertex.nb_issues()
                + unique_vertices_linked_to_multiple_corners.nb_issues()
+               + unique_vertices_linked_to_multiply_embedded_corner.nb_issues()
                + unique_vertices_linked_to_not_internal_nor_boundary_corner
                      .nb_issues()
                + unique_vertices_liked_to_not_boundary_line_corner.nb_issues();
@@ -61,6 +62,12 @@ namespace geode
             absl::StrAppend(
                 &message, unique_vertices_linked_to_multiple_corners.string() );
         }
+        if( unique_vertices_linked_to_multiply_embedded_corner.nb_issues()
+            != 0 )
+        {
+            absl::StrAppend( &message,
+                unique_vertices_linked_to_multiply_embedded_corner.string() );
+        }
         if( unique_vertices_linked_to_not_internal_nor_boundary_corner
                 .nb_issues()
             != 0 )
@@ -167,6 +174,29 @@ namespace geode
         return std::nullopt;
     }
 
+    std::optional< std::string >
+        BRepCornersTopology::corner_is_multiply_embedded(
+            index_t unique_vertex_index ) const
+    {
+        for( const auto& cmv :
+            brep_.component_mesh_vertices( unique_vertex_index ) )
+        {
+            if( cmv.component_id.type() == Corner3D::component_type_static()
+                && brep_.corner( cmv.component_id.id() ).is_active()
+                && brep_.nb_embeddings( cmv.component_id.id() ) > 1 )
+            {
+                return absl::StrCat( "unique vertex ", unique_vertex_index,
+                    " is associated to Corner ",
+                    brep_.corner( cmv.component_id.id() )
+                        .name()
+                        .value_or( cmv.component_id.id().string() ),
+                    " (", cmv.component_id.id().string(),
+                    "), which is embedded in several components." );
+            }
+        }
+        return std::nullopt;
+    }
+
     std::optional< std::string >
         BRepCornersTopology::corner_is_not_internal_nor_boundary(
             index_t unique_vertex_index ) const
@@ -300,6 +330,12 @@ namespace geode
                 result.unique_vertices_linked_to_multiple_corners.add_issue(
                     unique_vertex_id, problem_message.value() );
             }
+            if( const auto problem_message =
+                    corner_is_multiply_embedded( unique_vertex_id ) )
+            {
+                result.unique_vertices_linked_to_multiply_embedded_corner
+                    .add_issue( unique_vertex_id, problem_message.value() );
+            }
             if( const auto problem_message =
                     corner_is_not_internal_nor_boundary( unique_vertex_id ) )
             {

src/geode/inspector/validity/CMakeLists.txt

@@ -22,17 +22,21 @@ add_geode_library(
     NAME validity
     FOLDER "geode/inspector/validity"
     SOURCES
+        "brep_validity.cpp"
         "common.cpp"
         "edgedcurve_validity.cpp"
         "object_validity.cpp"
         "pointset_validity.cpp"
+        "section_validity.cpp"
         "solid_validity.cpp"
         "surface_validity.cpp"
     PUBLIC_HEADERS
+        "brep_validity.hpp"
         "common.hpp"
         "edgedcurve_validity.hpp"
         "object_validity.hpp"
         "pointset_validity.hpp"
+        "section_validity.hpp"
         "solid_validity.hpp"
         "surface_validity.hpp"
     PUBLIC_DEPENDENCIES