Merge pull request #182 from Geode-solutions/fix/checks_on_block_boundaries-not_called

fix(BlockTopology): Fixed call to checks on block surface boundaries

Author: BotellaA

.clang-format

@@ -1,5 +1,3 @@
-# DO NOT MODIFY DIRECTLY THIS FILE
-# LOOK AT https://github.com/Geode-solutions/actions
 AccessModifierOffset: -4
 AlignAfterOpenBracket: DontAlign
 AlignConsecutiveAssignments: false

bindings/python/tests/inspection/test-py-brep.py

@@ -221,9 +221,9 @@ def check_a1(verbose):
     else:
         print("model_A1 topology is invalid.")
     nb_model_issues = launch_topological_validity_checks(result.topology, verbose)
-    if nb_model_issues != 5201:
+    if nb_model_issues != 5191:
         raise ValueError(
-            "[Test] model model_A1 should have 5201 unique vertices with topological problems."
+            "[Test] model model_A1 should have 5191 unique vertices with topological problems."
         )
     nb_component_meshes_issues = launch_component_meshes_validity_checks(
         result.meshes, verbose
@@ -242,9 +242,9 @@ def inspect_model_A1(model_brep, verbose):
     else:
         print("model_A1_valid topology is invalid.")
     nb_model_issues = launch_topological_validity_checks(result.topology, verbose)
-    if nb_model_issues != 5201:
+    if nb_model_issues != 5191:
         raise ValueError(
-            "[Test] model model_A1_valid should have 5201 topological problems."
+            "[Test] model model_A1_valid should have 5191 topological problems."
         )
     nb_component_meshes_issues = launch_component_meshes_validity_checks(
         result.meshes, verbose
@@ -268,9 +268,9 @@ def inspect_model_mss(model_brep, verbose):
     else:
         print("model mss topology is invalid.")
     nb_model_issues = launch_topological_validity_checks(result.topology, verbose)
-    if nb_model_issues != 52:
+    if nb_model_issues != 50:
         raise ValueError(
-            "[Test] model mss.og_strm should have 37 topological problems, not "
+            "[Test] model mss.og_strm should have 50 topological problems, not "
             + str(nb_model_issues)
         )
     nb_component_meshes_issues = launch_component_meshes_validity_checks(

bindings/python/tests/validity/test-py-brep-validity.py

@@ -38,22 +38,22 @@ def data_dir():
 def check_a1():
     model_brep = geode.load_brep(data_dir() + "/model_A1.og_brep")
     result = validity.is_brep_valid(model_brep)
-    if result.nb_issues()!=7:
-        raise ValueError( "[Test] model model_A1 should have 7 issues." )
+    if result.nb_issues()!=8:
+        raise ValueError( "[Test] model model_A1 should have 8 issues." )
 
 
 def check_a1_valid():
     model_brep = geode.load_brep(data_dir() + "/model_A1_valid.og_brep")
     result = validity.is_brep_valid(model_brep)
-    if result.nb_issues()!=7:
-        raise ValueError( "[Test] model model_A1_valid should have 7 issues." )
+    if result.nb_issues()!=8:
+        raise ValueError( "[Test] model model_A1_valid should have 8 issues." )
 
 
 def check_model_mss():
     model_brep = geode.load_brep(data_dir() + "/mss.og_brep")
     result = validity.is_brep_valid(model_brep)
-    if result.nb_issues()!=5:
-        raise ValueError( "[Test] model_mss should have 5 issues." )
+    if result.nb_issues()!=4:
+        raise ValueError( "[Test] model_mss should have 4 issues." )
 
 
 def check_model_D():

include/geode/inspector/inspection/topology/brep_blocks_topology.hpp

@@ -49,10 +49,18 @@ namespace geode
             "Blocks without mesh (uuid listed)"
         };
         InspectionIssues< uuid > wrong_block_boundary_surface{
-            "Surfaces incorrectly bounding Blocks (uuids listed)"
+            "Blocks with boundary surface(s) not linked to another boundary "
+            "Surface by a line (Surface shouldn't be boundary or there is a "
+            "hole in the block boundaries)"
         };
         InspectionIssuesMap< index_t > blocks_not_linked_to_a_unique_vertex{
-            "Blocks containing mesh vertices not linked to unique vertices"
+            "Blocks mesh vertices not linked to unique vertices"
+        };
+        InspectionIssues< uuid > blocks_with_not_closed_boundary_surfaces{
+            "Blocks with non-closed boundary Surfaces"
+        };
+        InspectionIssues< index_t > model_boundaries_dont_form_a_closed_surface{
+            "ModelBoundaries do not form a valid closed surface"
         };
         InspectionIssues< index_t >
             unique_vertices_part_of_two_blocks_and_no_boundary_surface{
@@ -73,12 +81,6 @@ namespace geode
             unique_vertices_linked_to_a_single_and_invalid_surface{
                 "unique vertices linked to a single Surface that is invalid"
             };
-        InspectionIssues< uuid > blocks_with_not_closed_boundary_surfaces{
-            "Blocks with non-closed boundary Surfaces"
-        };
-        InspectionIssues< index_t > model_boundaries_dont_form_a_closed_surface{
-            "ModelBoundaries are not valid"
-        };
         InspectionIssues< index_t >
             unique_vertex_linked_to_multiple_invalid_surfaces{
                 "unique vertices linked to multiple Surfaces in an invalid way"