feat(Validity): Added validity checks for models

MelchiorSchuh · MelchiorSchuh · commit cabceafb54bc · 2026-06-09T14:29:39.000+02:00
diff --git a/bindings/python/src/inspection/topology/brep_topology.hpp b/bindings/python/src/inspection/topology/brep_topology.hpp
@@ -49,9 +49,10 @@ namespace geode
                 "unique_vertices_linked_to_not_internal_nor_boundary_corner",
                 &BRepCornersTopologyInspectionResult::
                     unique_vertices_linked_to_not_internal_nor_boundary_corner )
-            .def_readwrite( "unique_vertices_liked_to_not_boundary_line_corner",
+            .def_readwrite(
+                "unique_vertices_linked_to_not_boundary_line_corner",
                 &BRepCornersTopologyInspectionResult::
-                    unique_vertices_liked_to_not_boundary_line_corner )
+                    unique_vertices_linked_to_not_boundary_line_corner )
             .def( "string", &BRepCornersTopologyInspectionResult::string )
             .def( "inspection_type",
                 &BRepCornersTopologyInspectionResult::inspection_type );
diff --git a/bindings/python/tests/inspection/test-py-brep.py b/bindings/python/tests/inspection/test-py-brep.py
@@ -36,7 +36,7 @@ def corners_topological_validity(result, verbose):
     for corner_issue in result.corners_not_linked_to_a_unique_vertex.issues_map():
         nb_issues += corner_issue[1].nb_issues()
     nb_issues += result.corners_not_meshed.nb_issues()
-    nb_issues += result.unique_vertices_liked_to_not_boundary_line_corner.nb_issues()
+    nb_issues += result.unique_vertices_linked_to_not_boundary_line_corner.nb_issues()
     nb_issues += result.unique_vertices_linked_to_multiple_corners.nb_issues()
     nb_issues += (
         result.unique_vertices_linked_to_not_internal_nor_boundary_corner.nb_issues()
diff --git a/examples/model_inspection.py b/examples/model_inspection.py
@@ -85,16 +85,16 @@ def check_unique_vertices_linked_to_not_internal_nor_boundary_corner(brep_inspec
         )
 
 
-def check_unique_vertices_liked_to_not_boundary_line_corner(brep_inspector):
-    unique_vertices_liked_to_not_boundary_line_corner = (
-        brep_inspector.unique_vertices_liked_to_not_boundary_line_corner()
+def check_unique_vertices_linked_to_not_boundary_line_corner(brep_inspector):
+    unique_vertices_linked_to_not_boundary_line_corner = (
+        brep_inspector.unique_vertices_linked_to_not_boundary_line_corner()
     )
     print(
         "There are ",
-        len(unique_vertices_liked_to_not_boundary_line_corner),
+        len(unique_vertices_linked_to_not_boundary_line_corner),
         " corner vertices part of a line but not its boundary.",
     )
-    for vertex_index in unique_vertices_liked_to_not_boundary_line_corner:
+    for vertex_index in unique_vertices_linked_to_not_boundary_line_corner:
         print(
             "Model unique vertex with index ",
             vertex_index,
@@ -271,7 +271,7 @@ def launch_topological_validity_checks(brep_inspector):
     check_unique_vertices_linked_to_multiple_corners(brep_inspector)
     check_unique_vertices_linked_to_multiple_internals_corner(brep_inspector)
     check_unique_vertices_linked_to_not_internal_nor_boundary_corner(brep_inspector)
-    check_unique_vertices_liked_to_not_boundary_line_corner(brep_inspector)
+    check_unique_vertices_linked_to_not_boundary_line_corner(brep_inspector)
     check_unique_vertices_linked_to_line_with_wrong_relationship_to_surface(
         brep_inspector
     )
diff --git a/include/geode/inspector/inspection/topology/brep_corners_topology.hpp b/include/geode/inspector/inspection/topology/brep_corners_topology.hpp
@@ -63,7 +63,7 @@ namespace geode
                 "boundary nor internal status"
             };
         InspectionIssues< index_t >
-            unique_vertices_liked_to_not_boundary_line_corner{
+            unique_vertices_linked_to_not_boundary_line_corner{
                 "unique vertices linked to a Line's Corner without boundary "
                 "status"
             };
diff --git a/src/geode/inspector/inspection/topology/brep_corners_topology.cpp b/src/geode/inspector/inspection/topology/brep_corners_topology.cpp
@@ -42,7 +42,7 @@ namespace geode
                + unique_vertices_linked_to_multiply_embedded_corner.nb_issues()
                + unique_vertices_linked_to_not_internal_nor_boundary_corner
                      .nb_issues()
-               + unique_vertices_liked_to_not_boundary_line_corner.nb_issues();
+               + unique_vertices_linked_to_not_boundary_line_corner.nb_issues();
     }
 
     std::string BRepCornersTopologyInspectionResult::string() const
@@ -76,10 +76,11 @@ namespace geode
                 unique_vertices_linked_to_not_internal_nor_boundary_corner
                     .string() );
         }
-        if( unique_vertices_liked_to_not_boundary_line_corner.nb_issues() != 0 )
+        if( unique_vertices_linked_to_not_boundary_line_corner.nb_issues()
+            != 0 )
         {
             absl::StrAppend( &message,
-                unique_vertices_liked_to_not_boundary_line_corner.string() );
+                unique_vertices_linked_to_not_boundary_line_corner.string() );
         }
         if( !message.empty() )
         {
@@ -347,7 +348,7 @@ namespace geode
                     corner_is_part_of_line_but_not_boundary(
                         unique_vertex_id ) )
             {
-                result.unique_vertices_liked_to_not_boundary_line_corner
+                result.unique_vertices_linked_to_not_boundary_line_corner
                     .add_issue( unique_vertex_id, problem_message.value() );
             }
         }
diff --git a/src/geode/inspector/validity/brep_validity.cpp b/src/geode/inspector/validity/brep_validity.cpp
@@ -185,12 +185,12 @@ namespace
                     .unique_vertices_linked_to_not_internal_nor_boundary_corner
                     .string() );
         }
-        if( corners_topo.unique_vertices_liked_to_not_boundary_line_corner
+        if( corners_topo.unique_vertices_linked_to_not_boundary_line_corner
                 .nb_issues()
             > 0 )
         {
             invalidities.invalidities.push_back(
-                corners_topo.unique_vertices_liked_to_not_boundary_line_corner
+                corners_topo.unique_vertices_linked_to_not_boundary_line_corner
                     .string() );
         }
     }
diff --git a/tests/inspection/test-brep.cpp b/tests/inspection/test-brep.cpp
@@ -42,7 +42,7 @@ geode::index_t corners_topological_validity(
     }
     nb_issues += result.corners_not_meshed.nb_issues();
     nb_issues +=
-        result.unique_vertices_liked_to_not_boundary_line_corner.nb_issues();
+        result.unique_vertices_linked_to_not_boundary_line_corner.nb_issues();
     nb_issues += result.unique_vertices_linked_to_multiple_corners.nb_issues();
     nb_issues +=
         result.unique_vertices_linked_to_multiply_embedded_corner.nb_issues();

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ namespace geode`
`42`	`42`	`+ unique_vertices_linked_to_multiply_embedded_corner.nb_issues()`
`43`	`43`	`+ unique_vertices_linked_to_not_internal_nor_boundary_corner`
`44`	`44`	`.nb_issues()`
`45`		`- + unique_vertices_liked_to_not_boundary_line_corner.nb_issues();`
	`45`	`+ + unique_vertices_linked_to_not_boundary_line_corner.nb_issues();`
`46`	`46`	`}`
`47`	`47`
`48`	`48`	`std::string BRepCornersTopologyInspectionResult::string() const`
`@@ -76,10 +76,11 @@ namespace geode`
`76`	`76`	`unique_vertices_linked_to_not_internal_nor_boundary_corner`
`77`	`77`	`.string() );`
`78`	`78`	`}`
`79`		`- if( unique_vertices_liked_to_not_boundary_line_corner.nb_issues() != 0 )`
	`79`	`+ if( unique_vertices_linked_to_not_boundary_line_corner.nb_issues()`
	`80`	`+ != 0 )`
`80`	`81`	`{`
`81`	`82`	`absl::StrAppend( &message,`
`82`		`- unique_vertices_liked_to_not_boundary_line_corner.string() );`
	`83`	`+ unique_vertices_linked_to_not_boundary_line_corner.string() );`
`83`	`84`	`}`
`84`	`85`	`if( !message.empty() )`
`85`	`86`	`{`
`@@ -347,7 +348,7 @@ namespace geode`
`347`	`348`	`corner_is_part_of_line_but_not_boundary(`
`348`	`349`	`unique_vertex_id ) )`
`349`	`350`	`{`
`350`		`- result.unique_vertices_liked_to_not_boundary_line_corner`
	`351`	`+ result.unique_vertices_linked_to_not_boundary_line_corner`
`351`	`352`	`.add_issue( unique_vertex_id, problem_message.value() );`
`352`	`353`	`}`
`353`	`354`	`}`
Original file line number	Diff line number	Diff line change
`@@ -185,12 +185,12 @@ namespace`
`185`	`185`	`.unique_vertices_linked_to_not_internal_nor_boundary_corner`
`186`	`186`	`.string() );`
`187`	`187`	`}`
`188`		`- if( corners_topo.unique_vertices_liked_to_not_boundary_line_corner`
	`188`	`+ if( corners_topo.unique_vertices_linked_to_not_boundary_line_corner`
`189`	`189`	`.nb_issues()`
`190`	`190`	`> 0 )`
`191`	`191`	`{`
`192`	`192`	`invalidities.invalidities.push_back(`
`193`		`- corners_topo.unique_vertices_liked_to_not_boundary_line_corner`
	`193`	`+ corners_topo.unique_vertices_linked_to_not_boundary_line_corner`
`194`	`194`	`.string() );`
`195`	`195`	`}`
`196`	`196`	`}`
Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ geode::index_t corners_topological_validity(`
`42`	`42`	`}`
`43`	`43`	`nb_issues += result.corners_not_meshed.nb_issues();`
`44`	`44`	`nb_issues +=`
`45`		`- result.unique_vertices_liked_to_not_boundary_line_corner.nb_issues();`
	`45`	`+ result.unique_vertices_linked_to_not_boundary_line_corner.nb_issues();`
`46`	`46`	`nb_issues += result.unique_vertices_linked_to_multiple_corners.nb_issues();`
`47`	`47`	`nb_issues +=`
`48`	`48`	`result.unique_vertices_linked_to_multiply_embedded_corner.nb_issues();`