-
Notifications
You must be signed in to change notification settings - Fork 0
Spatial_window #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Spatial_window #27
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| /* | ||
| * Copyright (c) 2019 - 2025 Geode-solutions | ||
| * | ||
| * Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| * of this software and associated documentation files (the "Software"), to deal | ||
| * in the Software without restriction, including without limitation the rights | ||
| * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| * copies of the Software, and to permit persons to whom the Software is | ||
| * furnished to do so, subject to the following conditions: | ||
| * | ||
| * The above copyright notice and this permission notice shall be included in | ||
| * all copies or substantial portions of the Software. | ||
| * | ||
| * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| * SOFTWARE. | ||
| * | ||
| */ | ||
|
|
||
| #include <geode/stochastic/spatial/spatial_domain.hpp> | ||
|
|
||
| namespace | ||
| { | ||
| template < geode::index_t dimension > | ||
| void declare_spatial_domain( pybind11::module& module ) | ||
| { | ||
| using Domain = geode::SpatialDomain< dimension >; | ||
| using BBox = geode::BoundingBox< dimension >; | ||
|
|
||
| const auto pyclass_name = | ||
| "SpatialDomain" + std::to_string( dimension ) + "D"; | ||
|
|
||
| pybind11::class_< Domain >( module, pyclass_name.c_str() ) | ||
| .def( pybind11::init< const BBox&, double >(), | ||
| pybind11::arg( "domain" ), pybind11::arg( "buffer_size" ), | ||
| R"doc( | ||
| Create a spatial domain composed of: | ||
|
|
||
| - a core domain (the VOI) | ||
| - a buffer zone | ||
| - the extended domain (domain + buffer) | ||
|
|
||
| Arguments: | ||
| domain (BoundingBox): main domain / VOI | ||
| buffer_size (float): buffer thickness | ||
| )doc" ); | ||
| } | ||
| } // namespace | ||
| namespace geode | ||
| { | ||
| void define_spatial_domain( pybind11::module& module ) | ||
| { | ||
| declare_spatial_domain< 2 >( module ); | ||
| declare_spatial_domain< 3 >( module ); | ||
| } | ||
| } // namespace geode |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -28,60 +28,72 @@ | |||||
|
|
||||||
| #include <geode/stochastic/sampling/direct/object_set_sampler/object_set_sampler.hpp> | ||||||
| #include <geode/stochastic/sampling/direct/point_uniform_sampler.hpp> | ||||||
| #include <geode/stochastic/spatial/spatial_domain.hpp> | ||||||
|
|
||||||
| namespace geode | ||||||
| { | ||||||
| template < index_t dimension > | ||||||
| class UniformPointSetSampler : public ObjectSetSampler< Point< dimension > > | ||||||
| { | ||||||
| public: | ||||||
| UniformPointSetSampler( const BoundingBox< dimension >& box ) | ||||||
| : ObjectSetSampler< Point< dimension > >{}, box_( box ) | ||||||
| UniformPointSetSampler( const SpatialDomain< dimension >& domain ) | ||||||
| : ObjectSetSampler< Point< dimension > >{}, domain_( domain ) | ||||||
| { | ||||||
| auto volume = box_.n_volume(); | ||||||
| auto volume = domain_.extended_n_volume(); | ||||||
| OPENGEODE_EXCEPTION( volume != 0., | ||||||
| "[PointSetSampler] - Undefined Bounding Box (volume ==0)." ); | ||||||
| "[PointSetSampler] - Undefined Extended Bounding " | ||||||
| "Box (volume ==0)." ); | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| this->log_pdf_ = -std::log( volume ); | ||||||
| step_move_ = define_step_for_move(); | ||||||
| OPENGEODE_EXCEPTION( step_move_ > 0., | ||||||
| "[PointSetSampler] - Undefined step length for move (value == ", | ||||||
| step_move_, ")." ); | ||||||
| } | ||||||
|
|
||||||
| Point< dimension > sample( RandomEngine& engine ) const override | ||||||
| { | ||||||
| return PointUniformSampler::sample< dimension >( engine, box_ ); | ||||||
| return PointUniformSampler::sample< dimension >( | ||||||
| engine, domain_.extended_box() ); | ||||||
| } | ||||||
|
|
||||||
| Point< dimension > change( | ||||||
| const Point< dimension >& obj, RandomEngine& engine ) const override | ||||||
| { | ||||||
| double ratio = 0.1; | ||||||
| geode::Sphere< dimension > ball{ obj, | ||||||
| ratio * std::get< 1 >( box_.smallest_length() ) }; | ||||||
| geode::Sphere< dimension > ball{ obj, step_move_ }; | ||||||
|
|
||||||
| auto new_point = | ||||||
| PointUniformSampler::sample< dimension >( engine, ball ); | ||||||
| constexpr index_t max_try{ 100 }; | ||||||
| for( const auto try_id : geode::Range{ max_try } ) | ||||||
| { | ||||||
| if( box_.contains( new_point ) ) | ||||||
| if( domain_.extended_contains( new_point ) ) | ||||||
| { | ||||||
| return new_point; | ||||||
| } | ||||||
| new_point = | ||||||
| PointUniformSampler::sample< dimension >( engine, ball ); | ||||||
| } | ||||||
| throw OpenGeodeException( absl::StrCat( | ||||||
| "[PointSampler] - Cannot find a point in the box: ", | ||||||
| box_.string() ) ); | ||||||
| throw OpenGeodeException( | ||||||
| absl::StrCat( "[PointSampler] - Cannot find a point in the " | ||||||
| "extended domain" ) ); | ||||||
| return obj; | ||||||
| } | ||||||
|
|
||||||
| private: | ||||||
| double define_step_for_move() | ||||||
| { | ||||||
| double ratio = 0.1; | ||||||
| return ratio * domain_.smallest_length(); | ||||||
| } | ||||||
|
|
||||||
| bool is_valid_object( const Point< dimension >& obj ) const override | ||||||
| { | ||||||
| return box_.contains( obj ); | ||||||
| return domain_.extended_contains( obj ); | ||||||
| } | ||||||
|
|
||||||
| private: | ||||||
| BoundingBox< dimension > box_; | ||||||
| const SpatialDomain< dimension >& domain_; | ||||||
| double step_move_{ 0. }; | ||||||
| }; | ||||||
|
|
||||||
| } // namespace geode | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.