Fix/unused params#180
Merged
Merged
Conversation
…b-Back into fix/unused_params
removed unnecessary attr to mesh_component schema pull from latest next
adapt routes and schemas
renamed test
…ta_folder_path, add get method
BotellaA
approved these changes
Sep 8, 2025
Comment on lines
+44
to
+45
| @classmethod | ||
| def get(cls, data_id: str) -> "Data | None": |
Member
There was a problem hiding this comment.
Suggested change
| @classmethod | |
| def get(cls, data_id: str) -> "Data | None": | |
| @staticmethod | |
| def get(data_id: str) -> "Data | None": |
Contributor
Author
There was a problem hiding this comment.
Les 2 fonctionnent, mais si on choisit d'utiliser @staticmethod, c'est un peu différent : fonction ne dépendant pas de la classe et il faut ré adapter les appels à la méthode get en précisant le model Data en paramètre
Je vais faire un commit avec les changements nécessaires
@BotellaA
changed classmethod to staticmethod in Data model renamed load function
…s/OpenGeodeWeb-Back into fix/unused_params
Member
|
🎉 This PR is included in version 5.10.0-rc.9 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Member
|
🎉 This PR is included in version 5.10.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.