Merge pull request #430 from Geode-solutions/fix/tests_e2e_points_size

BotellaA · web-flow · commit c52859390b86 · 2026-06-23T18:15:24.000+02:00
Fix/tests e2e points size
diff --git a/app/components/CameraManager/List.vue b/app/components/CameraManager/List.vue
@@ -54,7 +54,7 @@ async function saveRename() {
           color="success"
           size="x-small"
           class="mr-1"
-          :data-testid="'restoreCameraPosition' + position.name + 'Button'"
+          :data-testid="`restoreCameraPosition${position.name}Button`"
           @click="restorePosition(position.id)"
         >
           <v-icon size="14">mdi-play</v-icon>
diff --git a/app/components/CameraOrientation.vue b/app/components/CameraOrientation.vue
@@ -212,7 +212,7 @@ watch(hoveredFace, (newFace, oldFace) => {
         size="32"
         class="satellite-node position-absolute"
         :style="orientation.position"
-        :data-testid="'cameraOrientation' + orientation.vtkKey + 'Button'"
+        :data-testid="`cameraOrientation${orientation.vtkKey}Button`"
         @mouseenter="hoveredFace = orientation.face"
         @mouseleave="hoveredFace = undefined"
         @click.stop="emit('select', orientation.value)"
@@ -242,7 +242,7 @@ watch(hoveredFace, (newFace, oldFace) => {
           size="32"
           variant="text"
           class="ma-1"
-          :data-testid="'cameraOrientation' + orientation.vtkKey + 'Button'"
+          :data-testid="`cameraOrientation${orientation.vtkKey}Button`"
           @mouseenter="hoveredFace = orientation.face"
           @mouseleave="hoveredFace = undefined"
           @click.stop="emit('select', orientation.value)"
diff --git a/app/components/FileUploader.vue b/app/components/FileUploader.vue
@@ -129,9 +129,9 @@ watch(
     />
     <DragAndDrop
       ref="dragAndDropRef"
-      class="d-none"
       :multiple
       :accept
+      :inline="false"
       @files-selected="processSelectedFiles"
     />
   </template>
diff --git a/app/components/HybridRenderingView.vue b/app/components/HybridRenderingView.vue
@@ -95,10 +95,13 @@ async function handleClick(event) {
   </ClientOnly>
 </template>
 
-<style scoped>
-:deep(img) {
-  pointer-events: none;
+<style>
+[data-testid="hybridViewer"] img {
+  pointer-events: none !important;
 }
+</style>
+
+<style scoped>
 .picking-cursor {
   cursor: crosshair !important;
 }
diff --git a/app/components/HybridViewerTooltip.vue b/app/components/HybridViewerTooltip.vue
@@ -63,6 +63,11 @@ const originalIndex = computed(() => {
   }
   return Math.floor(Number(originalId));
 });
+const RESERVED_ATTRIBUTE_KEYS = new Set([
+  "coordinates",
+  "vtkOriginalCellIds",
+  "vtkOriginalPointIds",
+]);
 
 const hasOtherAttributes = computed(() => {
   const attributes = hybridViewerStore.hoverData?.attributes || {};
@@ -71,6 +76,16 @@ const hasOtherAttributes = computed(() => {
   );
 });
 
+const sortedAttributes = computed(() => {
+  const attributes = hybridViewerStore.hoverData?.attributes || {};
+  return (
+    Object.entries(attributes)
+      .filter(([key]) => !RESERVED_ATTRIBUTE_KEYS.has(key))
+      // oxlint-disable-next-line unicorn/no-array-sort
+      .sort(([keyA], [keyB]) => keyA.localeCompare(keyB))
+  );
+});
+
 function capitalize(val) {
   if (!val) {
     return "";
@@ -156,15 +171,8 @@ function formatAttributeValue(val) {
               {{ Number(hybridViewerStore.hoverData.attributes.coordinates[2]).toFixed(3) }} ]
             </span>
           </v-col>
-          <template v-for="(val, name) in hybridViewerStore.hoverData.attributes" :key="name">
-            <v-col
-              v-if="
-                name !== 'coordinates' &&
-                name !== 'vtkOriginalCellIds' &&
-                name !== 'vtkOriginalPointIds'
-              "
-              class="d-flex justify-space-between ga-3"
-            >
+          <template v-for="[name, val] in sortedAttributes" :key="name">
+            <v-col class="d-flex justify-space-between ga-3">
               <span class="tooltip-label">{{ capitalize(name) }}:</span>
               <span class="tooltip-value font-mono">
                 {{ formatAttributeValue(val) }}
@@ -183,7 +191,7 @@ function formatAttributeValue(val) {
   pointer-events: none;
   z-index: 4;
   min-width: 200px;
-  max-width: 450px;
+  max-width: max-content;
   transition: opacity 0.15s ease;
 }
 .font-mono {
@@ -197,10 +205,12 @@ function formatAttributeValue(val) {
 .tooltip-label {
   color: #bdbdbd;
   font-weight: bold;
+  white-space: nowrap;
 }
 .tooltip-value {
   color: #a7ffeb;
   font-weight: 500;
+  white-space: nowrap;
 }
 .tooltip-value-dim {
   color: #eeeeee;
diff --git a/app/components/Screenshot.vue b/app/components/Screenshot.vue
@@ -102,10 +102,10 @@ watch(screenshot_type, (value) => {
               File
             </v-btn>
             <v-btn
+              data-testid="screenshotClipboardButton"
               value="clipboard"
               prepend-icon="mdi-content-copy"
               size="small"
-              data-testid="screenshotClipboardButton"
               class="text-caption text-none"
             >
               Clipboard
@@ -117,11 +117,11 @@ watch(screenshot_type, (value) => {
       <v-row dense v-if="screenshot_type === 'file'">
         <v-col cols="12" class="py-1">
           <v-text-field
+            data-testid="screenshotFileNameInput"
             v-model="filename"
             label="File name"
             variant="outlined"
             density="compact"
-            data-testid="screenshotFileNameInput"
             hide-details
             class="text-caption"
           ></v-text-field>
@@ -144,10 +144,10 @@ watch(screenshot_type, (value) => {
       <v-row dense>
         <v-col cols="12" class="py-1">
           <v-switch
+            data-testid="screenshotIncludeBackgroundSwitch"
             v-model="include_background"
             :disabled="screenshot_type === 'file' && output_extension !== 'png'"
             label="Include background"
-            data-testid="screenshotIncludeBackgroundSwitch"
             density="compact"
             hide-details
             inset
@@ -170,10 +170,10 @@ watch(screenshot_type, (value) => {
           Cancel
         </v-btn>
         <v-btn
+          data-testid="screenshotActionButton"
           variant="outlined"
           size="small"
           class="text-caption text-none"
-          data-testid="screenshotActionButton"
           :disabled="(screenshot_type === 'file' && !filename) || !output_extension"
           color="white"
           @click="takeScreenshot()"
diff --git a/app/components/ViewToolbar.vue b/app/components/ViewToolbar.vue
@@ -62,8 +62,8 @@ const camera_options = computed(() => [
     menu: [
       {
         title: "Cells",
-        icon: "mdi-select-all",
         testId: "highlightOnHoverCellsButton",
+        icon: "mdi-select-all",
         action: () => {
           if (
             hybridViewerStore.is_hover_highlight &&
@@ -79,8 +79,8 @@ const camera_options = computed(() => [
       },
       {
         title: "Points",
-        icon: "mdi-select-drag",
         testId: "highlightOnHoverPointsButton",
+        icon: "mdi-select-drag",
         action: () => {
           if (
             hybridViewerStore.is_hover_highlight &&
@@ -180,9 +180,9 @@ const camera_options = computed(() => [
             <v-row dense>
               <v-col v-for="item in camera_option.menu" :key="item.title">
                 <ActionButton
+                  :data-testid="item.testId"
                   :icon="item.icon"
                   :tooltip="item.title"
-                  :data-testid="item.testId"
                   :color="
                     hybridViewerStore.is_hover_highlight &&
                     hybridViewerStore.hover_highlight_field_type ===
diff --git a/app/components/Viewer/EdgedCurve/SpecificEdgesOptions.vue b/app/components/Viewer/EdgedCurve/SpecificEdgesOptions.vue
@@ -121,7 +121,7 @@ const edge_attribute_color_map = computed({
       <ViewerOptionsVisibilitySwitch data-testid="meshEdgesVisibilitySwitch" v-model="visibility" />
       <template v-if="visibility">
         <v-divider class="my-2" />
-        <ViewerOptionsWidthSlider v-model="width" />
+        <ViewerOptionsWidthSlider data-testid="meshEdgesWidthSlider" v-model="width" />
         <ViewerOptionsColoringTypeSelector
           :id="id"
           v-model:coloring_style_key="coloring_style_key"
diff --git a/app/components/Viewer/Generic/Mesh/CellsOptions.vue b/app/components/Viewer/Generic/Mesh/CellsOptions.vue
@@ -121,6 +121,7 @@ const cell_attribute_color_map = computed({
     <template #options>
       <ViewerOptionsVisibilitySwitch data-testid="meshCellsVisibilitySwitch" v-model="visibility" />
       <template v-if="visibility">
+        <v-divider />
         <ViewerOptionsColoringTypeSelector
           :id="id"
           v-model:coloring_style_key="coloring_style_key"
diff --git a/app/components/Viewer/Generic/Mesh/EdgesOptions.vue b/app/components/Viewer/Generic/Mesh/EdgesOptions.vue
@@ -66,7 +66,14 @@ const color = computed({
     :btnImage="btnImage"
   >
     <template #options>
-      <ViewerOptionsVisibilitySwitch data-testid="meshEdgesVisibilitySwitch" v-model="visibility" />
+      <v-row>
+        <v-col>
+          <ViewerOptionsVisibilitySwitch
+            data-testid="meshEdgesVisibilitySwitch"
+            v-model="visibility"
+          />
+        </v-col>
+      </v-row>
       <template v-if="visibility">
         <v-divider class="my-2" />
         <ViewerOptionsWidthSlider data-testid="meshEdgesWidthSlider" v-model="size" />
diff --git a/app/components/Viewer/Generic/Mesh/PointsOptions.vue b/app/components/Viewer/Generic/Mesh/PointsOptions.vue
@@ -93,10 +93,14 @@ const vertex_attribute_color_map = computed({
     :btnImage="btnImage"
   >
     <template #options>
-      <ViewerOptionsVisibilitySwitch
-        data-testid="meshPointsVisibilitySwitch"
-        v-model="visibility"
-      />
+      <v-row class="pa-1">
+        <v-col>
+          <ViewerOptionsVisibilitySwitch
+            data-testid="meshPointsVisibilitySwitch"
+            v-model="visibility"
+          />
+        </v-col>
+      </v-row>
       <template v-if="visibility">
         <v-divider class="my-2" />
         <ViewerOptionsSizeSlider data-testid="meshPointsSizeSlider" v-model="size" />
diff --git a/app/components/Viewer/Generic/Mesh/PolygonsOptions.vue b/app/components/Viewer/Generic/Mesh/PolygonsOptions.vue
@@ -11,10 +11,11 @@ const dataStyleStore = useDataStyleStore();
 const hybridViewerStore = useHybridViewerStore();
 const { applyBatchStyle } = useBatchStyle();
 
-const { itemProps, btnImage, tooltip } = defineProps({
+const { itemProps, btnImage, tooltip, capabilities } = defineProps({
   itemProps: { type: Object, required: true },
   btnImage: { type: String, required: true },
   tooltip: { type: String, required: false, default: "Polygons options" },
+  capabilities: { type: Object, default: () => ({}) },
 });
 
 const id = toRef(() => itemProps.id);
@@ -70,11 +71,13 @@ const textures = computed({
         v-model="visibility"
       />
       <template v-if="visibility">
+        <v-divider />
         <ViewerOptionsColoringTypeSelector
           :id="id"
           v-model:coloring_style_key="coloring_style_key"
           v-model:color="color"
           v-model:textures="textures"
+          :capabilities="capabilities"
         />
       </template>
     </template>
diff --git a/app/components/Viewer/Generic/Mesh/PolyhedraOptions.vue b/app/components/Viewer/Generic/Mesh/PolyhedraOptions.vue
@@ -117,6 +117,7 @@ const polyhedron_attribute_color_map = computed({
         v-model="visibility"
       />
       <template v-if="visibility">
+        <v-divider />
         <ViewerOptionsColoringTypeSelector
           :id="id"
           v-model:coloring_style_key="coloring_style_key"
diff --git a/app/components/Viewer/Generic/Model/BlocksOptions.vue b/app/components/Viewer/Generic/Model/BlocksOptions.vue
@@ -203,7 +203,7 @@ const polyhedronSchema = back_schemas.opengeodeweb_back.model_component_polyhedr
 
 <template>
   <OptionsSection title="Blocks Options" class="mt-4">
-    <VisibilitySwitch v-model="blocksVisibility" />
+    <VisibilitySwitch data-testid="modelBlocksVisibilitySwitch" v-model="blocksVisibility" />
     <ViewerOptionsColoringTypeSelector
       :id="modelId"
       :componentId="targetBlockIds[0]"
diff --git a/app/components/Viewer/Generic/Model/CornersOptions.vue b/app/components/Viewer/Generic/Model/CornersOptions.vue
@@ -13,6 +13,7 @@ const { modelId, cornerId, targetCornerIds } = defineProps({
 });
 
 const dataStyleStore = useDataStyleStore();
+console.log("CornersOptions setup!");
 const hybridViewerStore = useHybridViewerStore();
 
 // Visibility
@@ -140,7 +141,7 @@ const vertexSchema = back_schemas.opengeodeweb_back.model_component_vertex_attri
 
 <template>
   <OptionsSection title="Corners Options" class="mt-4">
-    <VisibilitySwitch v-model="cornersVisibility" />
+    <VisibilitySwitch data-testid="modelCornersVisibilitySwitch" v-model="cornersVisibility" />
     <ViewerOptionsColoringTypeSelector
       :id="modelId"
       :componentId="targetCornerIds[0]"
diff --git a/app/components/Viewer/Generic/Model/LinesOptions.vue b/app/components/Viewer/Generic/Model/LinesOptions.vue
@@ -199,7 +199,7 @@ const edgeSchema = back_schemas.opengeodeweb_back.model_component_edge_attribute
 
 <template>
   <OptionsSection title="Lines Options" class="mt-4">
-    <VisibilitySwitch v-model="linesVisibility" />
+    <VisibilitySwitch data-testid="modelLinesVisibilitySwitch" v-model="linesVisibility" />
     <ViewerOptionsColoringTypeSelector
       :id="modelId"
       :componentId="targetLineIds[0]"
diff --git a/app/components/Viewer/Generic/Model/ModelStyleCard.vue b/app/components/Viewer/Generic/Model/ModelStyleCard.vue
@@ -122,7 +122,7 @@ const modelComponentsColor = computed({
 <template>
   <v-sheet class="model-style-card" color="transparent">
     <OptionsSection title="Model Options">
-      <VisibilitySwitch v-model="modelVisibility" />
+      <VisibilitySwitch data-testid="modelStyleVisibilitySwitch" v-model="modelVisibility" />
     </OptionsSection>
 
     <OptionsSection v-if="!componentType && !componentId" title="Components Options" class="mt-4">
diff --git a/app/components/Viewer/Generic/Model/SurfacesOptions.vue b/app/components/Viewer/Generic/Model/SurfacesOptions.vue
@@ -207,7 +207,7 @@ const polygonSchema = back_schemas.opengeodeweb_back.model_component_polygon_att
 
 <template>
   <OptionsSection title="Surfaces Options" class="mt-4">
-    <VisibilitySwitch v-model="surfacesVisibility" />
+    <VisibilitySwitch data-testid="modelSurfacesVisibilitySwitch" v-model="surfacesVisibility" />
     <ViewerOptionsColoringTypeSelector
       :id="modelId"
       :componentId="targetSurfaceIds[0]"
diff --git a/app/components/Viewer/Options/TextureItem.vue b/app/components/Viewer/Options/TextureItem.vue
@@ -95,19 +95,19 @@ watch(textureId, (value) => {
       hide-details
     />
   </v-col>
-  <v-badge :model-value="textureId != ''" color="white" floating dot offset-x="10" offset-y="10">
-    <v-col cols="1" class="ma-1" justify="center" align="center">
+  <v-col cols="1" class="ma-1 d-flex justify-center align-center">
+    <v-badge :model-value="textureId !== ''" color="white" floating dot offset-x="10" offset-y="10">
       <FileUploader
-        @files_uploaded="files_uploaded_event($event, index)"
+        @files_uploaded="files_uploaded_event($event)"
         :accept="['image/png', 'image/jpeg', 'image/bmp']"
         :autoUpload="true"
         :multiple="true"
         :mini="true"
         class="mt-2"
       />
-    </v-col>
-  </v-badge>
-  <v-col v-if="textureName == '' || textureId == ''" cols="1">
+    </v-badge>
+  </v-col>
+  <v-col v-if="textureName === '' || textureId === ''" cols="1">
     <v-icon size="20" icon="mdi-close-circle" v-tooltip:bottom="'Invalid texture'" />
   </v-col>
 </template>
diff --git a/app/components/Viewer/Options/TexturesSelector.vue b/app/components/Viewer/Options/TexturesSelector.vue
@@ -10,7 +10,7 @@ const { id } = defineProps({
 const internal_textures = ref([]);
 
 onMounted(() => {
-  if (textures.value === null) {
+  if (textures.value === null || textures.value === undefined || textures.value.length === 0) {
     internal_textures.value = [{ id: "", texture_name: "" }];
   } else {
     internal_textures.value = textures.value;
@@ -29,8 +29,7 @@ function update_value_event($event, index) {
 </script>
 
 <template>
-  <v-row v-for="(texture, index) in internal_textures" :key="texture" align="center">
-    <br />
+  <v-row v-for="(texture, index) in internal_textures" :key="index" align="center" class="mt-2">
     <v-col cols="1" class="pa-0">
       <v-icon
         v-if="internal_textures.length > 1"
diff --git a/app/components/Viewer/PointSet/SpecificPointsOptions.vue b/app/components/Viewer/PointSet/SpecificPointsOptions.vue
diff --git a/app/components/Viewer/Solid/PolygonsOptions.vue b/app/components/Viewer/Solid/PolygonsOptions.vue
diff --git a/app/components/Viewer/Ui.vue b/app/components/Viewer/Ui.vue
diff --git a/app/utils/colormap.js b/app/utils/colormap.js
diff --git a/app/utils/default_styles/meshes.js b/app/utils/default_styles/meshes.js
diff --git a/app/utils/local/cleanup.js b/app/utils/local/cleanup.js
diff --git a/app/utils/local/microservices.js b/app/utils/local/microservices.js
diff --git a/app/utils/local/scripts.js b/app/utils/local/scripts.js
diff --git a/internal/stores/data_style/model/color.js b/internal/stores/data_style/model/color.js

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ async function saveRename() {`
`54`	`54`	`color="success"`
`55`	`55`	`size="x-small"`
`56`	`56`	`class="mr-1"`
`57`		`- :data-testid="'restoreCameraPosition' + position.name + 'Button'"`
	`57`	+ :data-testid="`restoreCameraPosition${position.name}Button`"
`58`	`58`	`@click="restorePosition(position.id)"`
`59`	`59`	`>`
`60`	`60`	`<v-icon size="14">mdi-play</v-icon>`